This repository was archived by the owner on Dec 22, 2020. It is now read-only.
improve package json - #58
Open
Gerhard Preuss (lipp) wants to merge 2 commits into
Open
Conversation
ali-hamud
self-requested a review
April 16, 2017 08:32
ali-hamud
suggested changes
Apr 16, 2017
| "scripts": { | ||
| "precontrib": "npm install -g typings typescript && npm install", | ||
| "contrib": "typings install && tsc" | ||
| "prepublish": "typings install && tsc" |
Contributor
There was a problem hiding this comment.
calling tsc after installing it via devDependencies does not work for me.
am I missing something here? maybe it worked for you because you have typescript installed globally?
Contributor
There was a problem hiding this comment.
tsc is important for incremental build.
Contributor
Author
There was a problem hiding this comment.
i'll check it out...
Gomas2523
approved these changes
Oct 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepublishscript (standard hook) instead ofcontrib + precontribprepublishis a standard hook that gets executed automatically afternpm i.It is also automatically executed during npm publish.