Skip to content

Update KeyVaultClient to SecretClient. - #67

Open
Tianyun Gao (MSFT) (Tianyun-G) wants to merge 4 commits into
microsoft:masterfrom
Tianyun-G:update_keyvault_sdk
Open

Update KeyVaultClient to SecretClient.#67
Tianyun Gao (MSFT) (Tianyun-G) wants to merge 4 commits into
microsoft:masterfrom
Tianyun-G:update_keyvault_sdk

Conversation

@Tianyun-G

@Tianyun-G Tianyun Gao (MSFT) (Tianyun-G) commented Jan 21, 2021

Copy link
Copy Markdown

Updated: CPVApplication, CSPApplication, PartnerConsent.

  • All these 3 projects updated ..\Utilities\KeyVaultProvider.cs
  • KeyVaultClient updated to SecretClient.

Jon Gallant (@jongio) for notification.

@kaminasy

Copy link
Copy Markdown
Contributor

Tianyun Gao (MSFT) (@Tianyun-G) is this ready for a review?

@Tianyun-G

Copy link
Copy Markdown
Author

kaminasy Yes, please review.

@kaminasy

Copy link
Copy Markdown
Contributor

Tianyun Gao (MSFT) (@Tianyun-G) I have reviewed your PR. Just to confirm for my end. Please confirm whether the application is running with all your changes with no issues.

@kaminasy

Copy link
Copy Markdown
Contributor

Tianyun Gao (MSFT) (@Tianyun-G) I have reviewed your PR. Just to confirm for my end. Please confirm whether the application is running with all your changes with no issues.

Ping?

@Tianyun-G

Copy link
Copy Markdown
Author

kaminasy - Hi, the application where I changed compile with no issue. We try to run this application but couldn't find the value of PartnerId and CustomerId link; Do you have any ideas ?

@Tianyun-G

Tianyun Gao (MSFT) (Tianyun-G) commented May 13, 2021

Copy link
Copy Markdown
Author

kaminasy Do you have any ideas ? Any progress?

@v-xuto

Copy link
Copy Markdown

kaminasy Do you have any ideas ?

@jongio

Copy link
Copy Markdown

kaminasy ?

@kaminasy

Copy link
Copy Markdown
Contributor

kaminasy ?

Please find your requested information in the email that I have sent earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants