Add QairtModelHandler input support to QairtPipelinePass#2545
Draft
qti-kromero wants to merge 1 commit into
Draft
Add QairtModelHandler input support to QairtPipelinePass#2545qti-kromero wants to merge 1 commit into
qti-kromero wants to merge 1 commit into
Conversation
Allow QairtPipelinePass to accept a QairtModelHandler as input in addition to HfModelHandler. This enables chaining two pipeline passes in an Olive recipe — the first pass exports an HF checkpoint via save_pretrained, and the second pass loads from that checkpoint as its model_id_or_path. When input is QairtModelHandler: model.model_path is used directly as model_id_or_path; the recipe must not also specify model_id_or_path (raises ValueError if it does); config.json and generation_config.json are copied from model.model_path rather than via snapshot_download.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if not isinstance(model, HfModelHandler): | ||
| raise ValueError(f"QairtPipelinePass requires HfModelHandler as input, got {type(model).__name__}") | ||
| if isinstance(model, HfModelHandler): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow QairtPipelinePass to accept a QairtModelHandler as input in addition to HfModelHandler. This enables chaining two pipeline passes in an Olive recipe — the first pass exports an HF checkpoint via save_pretrained, and the second pass loads from that checkpoint as its model_id_or_path.
When input is QairtModelHandler: model.model_path is used directly as model_id_or_path; the recipe must not also specify model_id_or_path (raises ValueError if it does); config.json and generation_config.json are copied from model.model_path rather than via snapshot_download.
Describe your changes
Checklist before requesting a review
lintrunner -a(Optional) Issue link