add time to first token in OnnxDiscrepancyCheck#2535
Open
xadupre wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds time-to-first-token and time-to-first-N-tokens latency metrics to OnnxDiscrepancyCheck’s generation comparison output, and updates tests accordingly.
Changes:
- Introduces a new
time_to_first_n_tokensconfig option and surfaces latency metrics for both Transformers and ORT GenAI generation. - Changes
compare_generationto return a results dictionary (instead of anint) and updates result aggregation/logging. - Updates ONNX discrepancy check tests to validate the new return shape and metric keys.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/passes/onnx/test_discrepancy_check.py | Adjusts assertions for the new dict return type and validates presence of new latency metric fields. |
| olive/passes/onnx/discrepancy_check.py | Adds latency measurement/reporting for TTFT/TTFN and changes generation comparison to return structured results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes