expose latencies with the speedup in OnnxDiscrepancyCheck#2534
Open
xadupre wants to merge 5 commits into
Open
Conversation
Member
Author
|
@copilot extend the existing unit test to cover the changes |
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
This PR enhances OnnxDiscrepancyCheck speed measurements by exposing the underlying per-iteration latencies (PyTorch and ONNX) in addition to the speedup ratio, making it easier to interpret which side changed.
Changes:
- Updates
_measure_speedupto return(pytorch_latency_s, onnx_latency_s, speedup)instead of onlyspeedup. - Stores
pytorch_latency_s,onnx_latency_s, andspeedupinto the results dict when timing is measured. - Adds a unit test verifying the new
_measure_speedupreturn tuple.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
olive/passes/onnx/discrepancy_check.py |
Returns and records both latencies alongside speedup in results. |
test/passes/onnx/test_discrepancy_check.py |
Adds coverage for the new tuple return contract of _measure_speedup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Speedup is not enough as a metric, latency must be added to understand which side is changing.