Skip to content

drivers: hv: clear halt when injecting SNP interrupts #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Brian-Perkins wants to merge 1 commit into
base: product/hcl-main/6.18
Choose a base branch
from
+42 −1
Open

drivers: hv: clear halt when injecting SNP interrupts #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion drivers/hv/mshv_vtl_main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,30 @@ static bool __mshv_pull_proxy_irr(struct mshv_vtl_run *run, struct page *apic_pa
return false;
}

#if defined(CONFIG_SEV_GUEST)
static void mshv_snp_clear_halt_if_irr_pending(struct mshv_vtl_run *run, struct page *apic_page)
{
u32 *apic_page_irr;

if (!apic_page || !(READ_ONCE(run->flags) & MSHV_VTL_RUN_FLAG_HALTED))
return;

apic_page_irr = (u32 *)((char *)page_address(apic_page) + APIC_IRR);

for (int i = 7; i >= 0; i--) {
if (READ_ONCE(apic_page_irr[i * 4])) {
u8 *offload_flags = &run->offload_flags;

(*offload_flags) &= ~MSHV_VTL_OFFLOAD_FLAG_HALT_HLT;
(*offload_flags) &= ~MSHV_VTL_OFFLOAD_FLAG_HALT_IDLE;
if (!(*offload_flags & MSHV_VTL_OFFLOAD_FLAG_HALT_OTHER))
run->flags &= ~MSHV_VTL_RUN_FLAG_HALTED;
return;
}
}
}
#endif

#else

static int mshv_create_apicid_to_cpuid_mapping(struct device *dev) { return 0; }
Expand Down Expand Up @@ -2014,10 +2038,12 @@ static bool mshv_tdx_try_handle_exit(struct mshv_vtl_run *run)
} else if (mshv_tdx_is_hlt(context)) {
ret_to_user = false;
mshv_tdx_handle_hlt_idle(context);
run->offload_flags &= ~MSHV_VTL_OFFLOAD_FLAG_HALT_IDLE;
run->offload_flags |= MSHV_VTL_OFFLOAD_FLAG_HALT_HLT;
} else if (mshv_tdx_is_idle(context)) {
ret_to_user = false;
mshv_tdx_handle_hlt_idle(context);
run->offload_flags &= ~MSHV_VTL_OFFLOAD_FLAG_HALT_HLT;
run->offload_flags |= MSHV_VTL_OFFLOAD_FLAG_HALT_IDLE;
}

Expand Down Expand Up @@ -2106,19 +2132,31 @@ static bool mshv_snp_try_handle_exit(struct mshv_vtl_run *run)
break;
case SVM_EXIT_HLT:
run->flags |= MSHV_VTL_RUN_FLAG_HALTED;
run->offload_flags &= ~MSHV_VTL_OFFLOAD_FLAG_HALT_IDLE;
run->offload_flags |= MSHV_VTL_OFFLOAD_FLAG_HALT_HLT;
goto handled;
case SVM_EXIT_IDLE_HLT:
run->flags |= MSHV_VTL_RUN_FLAG_HALTED;
run->offload_flags &= ~MSHV_VTL_OFFLOAD_FLAG_HALT_HLT;
run->offload_flags |= MSHV_VTL_OFFLOAD_FLAG_HALT_IDLE;
goto handled;
case SVM_EXIT_INTR:
/*
* mshv_snp_clear_exit_code() uses SVM_EXIT_INTR as a benign
* sentinel. If VTL2 was woken from native_safe_halt(), VTL0 did
* not run and the VMSA still contains that sentinel.
*/
if (run->flags & MSHV_VTL_RUN_FLAG_HALTED)
return true;
break;
case SVM_EXIT_MSR:
if (vmsa->rcx == HV_X64_MSR_GUEST_IDLE && !(vmsa->guest_exit_info_1 & 1)) {
/* The guest indicates it's idle by reading this synthetic MSR. */
vmsa->rax = 0;
vmsa->rdx = 0;
vmsa->rip = vmsa->guest_nrip;

run->offload_flags &= ~MSHV_VTL_OFFLOAD_FLAG_HALT_HLT;
run->offload_flags |= MSHV_VTL_OFFLOAD_FLAG_HALT_IDLE;
run->flags |= MSHV_VTL_RUN_FLAG_HALTED;

Expand Down Expand Up @@ -2223,7 +2261,10 @@ static bool mshv_pull_proxy_irr(struct mshv_vtl_run *run)
#endif
} else if (hv_isolation_type_snp()) {
#ifdef CONFIG_SEV_GUEST
ret = __mshv_pull_proxy_irr(run, snp_this_savic_page());
struct page *savic_page = snp_this_savic_page();

ret = __mshv_pull_proxy_irr(run, savic_page);
mshv_snp_clear_halt_if_irr_pending(run, savic_page);
#endif
}

Expand Down
Loading