Repository navigation
feat(chat): backport fragment feedback and selection actions to main - #296
Merged
Merged
Conversation
Capture selected completed response text, collect localized quote/comment templates in the owning thread draft, and preserve explicit Send as the only generation action. Cover selection, draft lifecycle and production chat regressions; document the demo MVP boundary. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit ac0517b)
Add Copy and Add as note alongside Comment in the selected-text popover. Preserve selected Markdown with the canonical Milkdown serializer, retain whole-response actions, and cover clipboard, note payload and browser interactions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 24eaf87)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-authorized Main backport of the Alpha-validated #294 and #295 for #293. The branch starts at
maincommitef481056f090f9065c2456ad13a461204a956b51and contains exactly twocherry-pick -xcommits:ac0517bb78abaaf1241ee387a7e4ca2d485f7524ce6f92fa168274e896fe6c14b00123f69c19509624eaf878d40af401ed3d2887cd1d8182c478b753f69bb4a024bc5e250b6bd9b73c0cc5b25cd4b5f7No unrelated Alpha commits are included. The original Alpha branches/history are not rewritten or changed. The only cherry-pick conflict was adjacent paragraphs in
docs/architecture/preview-workspace.md; resolved by retaining Main's existing empty-chat disclaimer documentation alongside the feature documentation. Main's existing disclaimer implementation and tests remain intact.Alpha-to-Main promotion compatibility
The user requires this backport not to make subsequent Alpha promotion harder. Compared Git's merge result before and after the backport against the same exact refs:
ef481056f090f9065c2456ad13a461204a956b51.10d48793c925f795ef3ed67a3e249ae5c3b81d76.git merge-tree --write-tree --name-only origin/main origin/alpha.git merge-tree --write-tree --name-only fix/issue-293-main origin/alpha.docs/architecture/preview-workspace.md; no new conflict is introduced. Existing promotion Promote Alpha to Main #283 is already conflicting before this backport.Thus, for these verified branch heads, this backport introduces no additional promotion conflicts or different final content. This is not a guarantee against future independent changes to either branch. Do not use an ours merge, drop Alpha commits, reset branches, or rewrite promotion history to mark the feature as delivered. A normal merge commit preserves the recorded backport history and source attribution. This PR does not merge or modify #283.
Behavior and scope
Select text within one completed assistant Markdown surface to Copy selected plain text, save selected Markdown as a Note, or Comment and explicitly Add to input. Multiple comments and free-form input combine in the thread draft before ordinary Send. Localized template labels, tooltips, clipboard retry, snapshot semantics and source provenance remain as validated on Alpha.
Whole-response bottom actions remain unchanged. No streaming comments, default presets, permanent annotations, new APIs/dependencies/storage, unrelated UI changes or release. No live-provider validation or manual cross-browser verification is claimed.
Validation on Main
pnpm typecheck,pnpm format,pnpm lint:fix,pnpm check:i18nandgit diff --checkpassed; formatting/linting left the backport worktree clean. Lint reports 0 errors and 350 existing warnings.