migrates test-data-shared to new location under AIFoundryLocal org#844
migrates test-data-shared to new location under AIFoundryLocal org#844prathikr wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the test-data-shared repository (which supplies LFS-tracked model files for the C++/C#/JS/Python test suites) to a new location under the AIFoundryLocal org. To consume it from the new location, the v2 Azure DevOps pipeline templates switch from the custom checkout-steps.yml template (an AzureCLI@2 clone via service connection) to native - checkout: test-data-shared steps, and the C++ build templates update FOUNDRY_TEST_DATA_DIR from $(Agent.BuildDirectory) to $(Build.SourcesDirectory) to match the native checkout layout.
Changes:
- Replace
checkout-steps.yml@selftemplate invocations with native- checkout: test-data-sharedacross the v2 C++ build steps and the C#/JS/Python test stages. - Repoint
FOUNDRY_TEST_DATA_DIRto$(Build.SourcesDirectory)\test-data-sharedin the three C++ build step templates.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| .pipelines/v2/templates/steps-build-windows.yml | Native checkout of test-data-shared + updated FOUNDRY_TEST_DATA_DIR; missing - checkout: self |
| .pipelines/v2/templates/steps-build-macos.yml | Same migration for the macOS C++ build job |
| .pipelines/v2/templates/steps-build-linux.yml | Same migration for the Linux C++ build job |
| .pipelines/v2/templates/stages-python.yml | Native checkout replacing template in 4 Python test stages |
| .pipelines/v2/templates/stages-js.yml | Native checkout replacing template in 3 JS test stages |
| .pipelines/v2/templates/stages-cs.yml | Native checkout replacing template in 4 C# test stages |
Key concerns raised in review: (1) no repository: test-data-shared resource is declared in resources.repositories (only 1ESPipelineTemplates exists in foundry-local-packaging.yml), so the native - checkout: test-data-shared steps will fail pipeline compilation; (2) the C++ build jobs add a native checkout without - checkout: self, leaving the SDK sources unavailable; and (3) introducing a second native checkout relocates self into a Foundry-Local subfolder, which breaks the many $(Build.SourcesDirectory)/sdk_v2/... path references in the downstream build/test step templates.
No description provided.