Skip to content

Fix website accessibility (MAS/WCAG) issues from Accessibility Insights FastPass#841

Open
MaanavD wants to merge 2 commits into
mainfrom
a11y-fastpass-fixes
Open

Fix website accessibility (MAS/WCAG) issues from Accessibility Insights FastPass#841
MaanavD wants to merge 2 commits into
mainfrom
a11y-fastpass-fixes

Conversation

@MaanavD

@MaanavD MaanavD commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Replaces #840 to move this PR off the fork branch and avoid the Vercel fork authorization gate.

Original fork PR: #840


What

Fixes the accessibility (Microsoft Accessibility Standards / WCAG) issues on the Foundry Local marketing website surfaced by Accessibility Insights FastPass (axe-core automated checks). This is the code-actionable portion of the June 2026 SDL Accessibility attestation (ADO User Story 97169 → Task 97172 "Run Accessibility Insights & Fix Bugs").

Findings & fixes

Rule (axe-core) WCAG Page Fix
heading-order 1.3.1 (A) Home The "Start with the SDK" card used <h3> directly under the hero <h1>, skipping <h2>. Promoted to <h2>.
image-redundant-alt best-practice Home + Models The nav logo <img> had alt="Foundry Local" immediately next to a visible "Foundry Local" text label, so screen readers announced it twice. Marked the image decorative (alt=""); the adjacent text already provides the accessible name.
page-has-heading-one best-practice Models The /models page had no <h1>. Added an sr-only <h1> and set the "Browse Foundry Models" filter card title to aria-level={2}, producing a valid h1 → h2 → h3 outline.

Verification

Ran axe-core (tags: wcag2a, wcag2aa, wcag21a, wcag21aa, best-practice) against the running dev site:

  • Home (light & dark): 0 violations (was heading-order + image-redundant-alt)
  • /models: 0 violations (was image-redundant-alt + page-has-heading-one); heading outline now L1 ΓåÆ L2 ΓåÆ L3

npm run check (svelte-check) holds at the pre-existing 17-error baseline ΓÇö these changes introduce no new type errors. (The repo is not currently Prettier-formatted; untouched files report the same Prettier warnings, so that's a pre-existing condition and out of scope here.)

Notes for the broader attestation

This PR closes the automated-scan ("Accessibility 2") portion. The remaining ADO tasks are process steps that require a human: requesting the Trusted Tester test pass (Accessibility 3), fixing any A11yMAS bugs they file (Accessibility 4), and publishing conformance documentation (Accessibility 5).

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

MaanavD and others added 2 commits June 25, 2026 11:44
…sights

Resolves axe-core/FastPass findings on the marketing site:

- heading-order (WCAG 1.3.1): promote the 'Start with the SDK' card heading from h3 to h2 so the hero h1 is followed by an h2.

- image-redundant-alt: the nav logo image duplicated the adjacent 'Foundry Local' text label; mark the image decorative (alt=\\) since the visible text already names it.

- page-has-heading-one: add an sr-only h1 to the /models page and set the 'Browse Foundry Models' filter card title to aria-level 2, giving a valid h1 -> h2 -> h3 outline.

Verified with axe-core (wcag2a/aa, wcag21a/aa, best-practice): 0 violations on home (light+dark) and /models, down from the findings above. No new svelte-check errors (17 pre-existing baseline unchanged).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Creates a no-op commit to request a fresh Vercel deployment for PR #840 without changing source content.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 25, 2026 19:04
@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
foundry-local Ready Ready Preview, Comment Jun 25, 2026 7:05pm

Request Review

@MaanavD

MaanavD commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

Replacement for fork PR #840. This PR uses an upstream branch so Vercel can deploy without the fork authorization gate.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes accessibility (Microsoft Accessibility Standards / WCAG) issues on the Foundry Local marketing website (www/) that were surfaced by Accessibility Insights FastPass (axe-core). The changes are small, markup-only adjustments to heading structure and image alt text to satisfy heading-order, image-redundant-alt, and page-has-heading-one rules.

Changes:

  • Promoted the "Start with the SDK" card heading from <h3> to <h2> so it no longer skips a level under the hero <h1>.
  • Marked the nav logo image as decorative (alt="") since the adjacent visible "Foundry Local" text already provides the accessible name.
  • Added an sr-only <h1> to the /models page and set the "Browse Foundry Models" card title to aria-level={2}, producing a valid h1 → h2 → h3 outline.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
www/src/lib/components/install-command.svelte Changes "Start with the SDK" heading from h3 to h2 to fix heading-order.
www/src/lib/components/home/nav.svelte Sets the nav logo alt="" to avoid redundant screen-reader announcement next to the visible label.
www/src/routes/models/+page.svelte Adds a screen-reader-only <h1> so the models page has a top-level heading.
www/src/routes/models/components/ModelFilters.svelte Sets the filter card title to level={2} to complete the heading outline.

I verified that Card.Title accepts the level prop (card-title.svelte defaults to 3 and maps it to aria-level), that LogoTransition forwards alt to its <img> elements (empty value correctly makes them decorative), that install-command.svelte is only used on the home page (so the h2 promotion sits under the hero h1), and that sr-only is an established utility class used elsewhere in the project. No issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants