Add files via upload - #548
Conversation
Co-authored-by: fechiram-ms <212867728+fechiram-ms@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 12 changed files in this pull request and generated no new comments.
Suppressed comments (9)
ERP/Commerce/AI-Search-for-Dynamics-365/README.md:133
- The
[releases]link points to a personal repository (fechiram_microsoft/AI-Search-for-Dynamics365) rather than this repository’s releases, so users following the README will land in the wrong place.
[releases]: https://github.com/fechiram_microsoft/AI-Search-for-Dynamics365/releases
ERP/Commerce/AI-Search-for-Dynamics-365/docs/azure-setup.md:194
- The guide instructs creating
#AISearchServiceEndpointin Key Vault, but no later step references this value (it only appears in this document). Either wire it into the F&O configuration steps or remove it to avoid unnecessary Key Vault secrets.
| `#AISearchServiceEndpoint` | Step 2 |
ERP/Commerce/AI-Search-for-Dynamics-365/docs/fno-configuration.md:26
- The dropdown value
AzureAISearchKeyis inconsistent with the secret naming used elsewhere in the docs (#AzureAISearchAccessKey). Using a different name here makes the setup steps ambiguous.
1. Enter the **AI Search endpoint** (copy the URI from the Azure AI Search resource) and select
`AzureAISearchKey` from the dropdown.
ERP/Commerce/AI-Search-for-Dynamics-365/docs/fno-model-deployment.md:36
- The link target
../fno-model-deployment.mddoes not exist (this file is alreadydocs/fno-model-deployment.md), so the link is broken.
For detailed deployment instructions, see **[Dynamics 365 Model Deployment](../fno-model-deployment.md)** guide.
ERP/Commerce/AI-Search-for-Dynamics-365/docs/fno-model-deployment.md:49
- The
[releases]link points to a different repository, so users will not find the expected.axpp/zip artifacts for this repo.
[releases]: https://github.com/fechiram_microsoft/AI-Search-for-Dynamics365/releases
ERP/Commerce/AI-Search-for-Dynamics-365/README.md:85
- The repository structure table points to
src/CCAISearch-Deploy/andsrc/Dynamics365/, but those paths are not present in this repo checkout. This will mislead anyone cloning the repo; either add the referenced folders or update the table to describe where these artifacts actually live (e.g., release artifacts).
This issue also appears on line 133 of the same file.
| **Function App code & deployment** | `src/CCAISearch-Deploy/` | .NET 8 C# | See [Azure setup](docs/azure-setup.md) Step 4 |
| **D365 X++ source & deployment** | `src/Dynamics365/` | X++/XML | See [Dynamics 365 Model Deployment](docs/fno-model-deployment.md) |
ERP/Commerce/AI-Search-for-Dynamics-365/docs/azure-setup.md:145
- The separator guidance uses
\|, but the function contract expects the literal|character; the backslash is only needed to escape a pipe in Markdown, not in JSON.
This issue also appears on line 194 of the same file.
| `separator` | ❌ | `,` | CSV column separator (use `\|` for VerticalBarSeparated) |
ERP/Commerce/AI-Search-for-Dynamics-365/docs/fno-configuration.md:15
- This step says there are "three" Key Vault secrets, but
docs/azure-setup.mddefines four values to store (including#AISearchServiceEndpoint). The lists should match so deployments don’t miss required values.
This issue also appears on line 25 of the same file.
3. Add the three secrets created in Key Vault:
- `#AzureAISearchAccessKey`
- `#StorageAccountConnectionString`
- `#DataUploadAzureFunctionAccessKey`
4. **Validate** each entry after inputting it.
ERP/Commerce/AI-Search-for-Dynamics-365/docs/fno-model-deployment.md:4
- This page describes an extracted X++ source folder layout (
Model/,Project/,ProjectItem/) and referencesFTA_CCAISearch_V7.axpp, but those folders aren’t present in this repo checkout and other docs refer toFTA_CCAISearch_V7_20260815.axpp. Either add the extracted source tree or update this document so it matches what’s actually in the repository and releases.
This issue also appears in the following locations of the same file:
- line 36
- line 49
This folder contains the extracted X++ source of the **AI Product Search** D365 Finance &
Operations model, as shipped in `FTA_CCAISearch_V7.axpp`.
No description provided.