Skip to content

feat: add dv-skill for Dataverse Business Skills management#64

Open
harishku wants to merge 2 commits into
mainfrom
users/harishku/adding-static-skill-to-let-plugin-know-how-to-use-dv-business-skill
Open

feat: add dv-skill for Dataverse Business Skills management#64
harishku wants to merge 2 commits into
mainfrom
users/harishku/adding-static-skill-to-let-plugin-know-how-to-use-dv-business-skill

Conversation

@harishku

Copy link
Copy Markdown

Adds a new dv-skill skill that teaches the agent how to manage Dataverse Business Skills (the skill entity) - list, create, update, delete skills and skill resources via the Python SDK.

Changes

  • New skill: .github/plugins/dataverse/skills/dv-skill/SKILL.md
  • Updated dv-overview routing table to include dv-skill
  • Added mandatory Consult Business Skills section to dv-data and dv-query
  • Registered dv-skill in auth.py allowed skills list
  • Added eval test: evals/tests/dv_skill.biceval.json
  • Version bump: 1.5.0 to 1.6.0 (MINOR - new skill addition)

@harishku harishku requested a review from a team May 28, 2026 23:10
@microsoft-github-policy-service

Copy link
Copy Markdown

@harishku please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@aadharshkannan

Copy link
Copy Markdown

Can we please see the eval results as part of the PR ?

@aadharshkannan aadharshkannan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like we have any evals run for these changes. Can we please get the evals ?


## Consult Business Skills — Mandatory

**Before generating any Python SDK code, consult Dataverse Business Skills.** Extract keywords from the user's request, query the skill entity, and incorporate any matching skill instructions as context. If no skills match, proceed normally. See **dv-skill** § Consult Helper for the full pattern.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have evals for these edits?

### List All Skills

```python
skills = client.records.get("skill", select="name,uniquename,description,body")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens in a non-python interface ? If I use CLI as an example

@suyask-msft suyask-msft left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genuinely useful capability — org-specific grounding for data ops is valuable. My feedback is about how it loads (it adds a mandatory per-op step to the hottest skills) and packaging — not the feature itself. Two things, details inline:

  1. (design) Should the consult be mandatory per-op, and does this need to be its own skill? — the main one. (Load it once per session, relevance-filtered: that's better for every org — whether they have 0 Business Skills or 500 — not just the ones without.)
  2. (footgun) .gitignore is shadowing the plugin's own scripts/.

Also: the dv-overview refactor (+8/-33, new tool-capabilities.md) and the dv_data eval rewrite (+142/-31) read as separate changes bundled in — easier to review split out, and worth confirming the dv_data eval isn't being loosened just to accept the new mandatory consult.


**If MCP tools are available** (`create_record`, `update_record`) and the task is ≤10 records, **use MCP directly — no script needed.** Only write a Python script when the task requires: bulk operations (10+ records), data transformation, retry logic, CSV import, or operations the SDK supports that MCP cannot (upsert, file uploads). Sequential MCP tool calls are not "multi-step logic" — use MCP for those.

## Consult Business Skills — Mandatory

@suyask-msft suyask-msft Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two concerns, and these are the main ones:

(a) This shouldn't be mandatory per-op. Very few orgs have Business Skills configured, so a mandatory skill-entity query before every dv-data (and dv-query) op taxes the 99% for the 1% — an extra round-trip + context on the hottest paths, usually returning nothing. (It also cuts against the de-steering direction in the design repo.)

Better: gate it on a cheap, once-per-session existence check — at dv-connect, detect whether the org has any active skill records and cache it; if none, this stays dormant (zero per-op cost). Better long-term: surface org guidance through the MCP server's instructions channel (the initialize handshake already returns per-org instructions) — loaded once, server-side, opt-in, no skill-prose coupling.

(b) Does this need to be a separate skill? The management half (CRUD on skill/skillresource + file upload) is just dv-data on one more entity — it could fold into dv-data as a short reference rather than a new always-loaded skill (which adds to Level-1 frontmatter for everyone). The "consult" half is a cross-cutting behavior, not a skill.

(Aside on naming: dv-skill is itself confusing — it collides with the plugin's own Agent Skills and this file's own "Business Skills" title; dv-business-skills would read better. But that's moot if we don't make it a separate skill.)

Future-proof either way: build the consult relevance-filtered + once-per-session now and it scales for free — if adoption surges it just starts returning results, no load-path change. And "separate skill" is a feature-depth call, not an adoption-count one — revisit a dedicated dv-business-skills skill only if Business Skills grow richer than CRUD.

Net: keep the capability, change the load model — orgs that use Business Skills get the grounding; everyone else pays nothing.

Comment thread .gitignore
# Local-only artifacts from running evals against a personal Dataverse org
.mcp.json
.env
scripts/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts/ is unanchored, so it matches .github/plugins/dataverse/scripts/ — which holds committed plugin code (auth.py, enable-mcp-client.py, mcp_proxy.py; this PR even edits auth.py). Already-tracked files stay tracked, but new files under any scripts/ would be silently ignored and hidden from git status — a footgun. Same risk with evals/*.py. Suggest anchoring to the specific local path (e.g. a root-level /scripts/ or the personal eval folder), not a blanket scripts/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants