Fix retired node's signature test#7909
Open
maxtropets wants to merge 4 commits into
Open
Conversation
maxtropets
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates an end-to-end reconfiguration test to correctly reason about when a retired node should stop emitting signatures, using the retired_committed field from the ledger and fixing node ID decoding while iterating ledger tables.
Changes:
- Renames and rewords the retired-node signature test to assert signatures stop after
retired_committedis observed in the ledger. - Fixes node ID handling when reading
public:ccf.gov.nodes.infofrom the ledger by decoding node IDs from bytes before comparing with signature records. - Updates the
run_all()sequence to call the renamed test.
Custom instructions used:
.github/copilot-instructions.md
cjen1-msft
reviewed
May 27, 2026
cjen1-msft
reviewed
May 27, 2026
| # Once that chain-closer has been seen, the node's | ||
| # retired_committed hook must have fired, so any further | ||
| # signature from that node is a violation. | ||
| assert not rc_globally_committed.get(signing_node, False), ( |
Contributor
There was a problem hiding this comment.
Suggested change
| assert not rc_globally_committed.get(signing_node, False), ( | |
| assert signing_node not in rc_globally_committed or not rc_globally_committed.get(signing_node), ( |
cjen1-msft
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblock #7904.
The test is incorrect due to missing
nid.decode()and fails in CI when corrected, as spotted during #7904.I've decided to make it a standalone fix for the sake of better visibility.
Retired node can sign until it's
retired_committed.