Cleaning up PBI report setup on company lifecycle operations + Cleaning Sustainability artifacts#8166
Draft
mynjj wants to merge 4 commits into
Draft
Cleaning up PBI report setup on company lifecycle operations + Cleaning Sustainability artifacts#8166mynjj wants to merge 4 commits into
mynjj wants to merge 4 commits into
Conversation
…rface Subscribe to "PBI Deployment Events".OnAfterDeleteAllDeploymentRecords (new BaseApp event that fires after the per-company Power BI deployment rows are wiped on env-copy and Copy Company) and clear the matching "PowerBI Reports Setup" Report Id / Name pairs. Replaces the two prior direct subscriptions to "Environment Cleanup" .OnClearCompanyConfig and Report "Copy Company" .OnAfterCreatedNewCompanyByCopyCompany — both BaseApp paths now route through PowerBIDeployment.DeleteAllRecords, which raises the new event. Switches from a hardcoded six-field clear to iterating Enum::"PBI Report Setup" and clearing each implementation's reported Id/Name field-no via RecordRef. Mirrors the populate-site pattern in PowerBISubscribers.OnReportDeployed exactly, so third-party extensions that register new app types are handled without changes here. Side-effect: Inventory Valuation (already in the enum but absent from the prior hardcoded list) is now also cleared. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sustainability is moving out of BCApps and will own its Power BI reports directly. Delete the runtime data assets shipped from PowerBIReports: - Power BI Files/Sustainability app/ (PBIP source: manifest + SemanticModel + Report folders) - Power BI Files/Translations/Sustainability app/ (24 .resx translations) - App/.resources/Sustainability app.pbix (compiled binary) - Translations/LocProject.json — remove the Sustainability LocItem entry that pointed at the now-deleted translations folder Backward-compat infrastructure is intentionally left in place for the deprecation/removal cycle: App/_Obsolete/Sustainability/ (1 tableext + 11 embedded pages), the matching #if not CLEAN27 permission set block, #if not CLEAN27 enum value blocks in the Test Library, and the page- validation YAML drill-through hashes. Those will go in a future CLEAN27 pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…res/pbiautdepl3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Linked work
Fixes AB#600448