Skip to content

Handle Nexus private DNS zone replacement in Deploy TRE workflow#4916

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-deploy-pr-deploy-tre
Draft

Handle Nexus private DNS zone replacement in Deploy TRE workflow#4916
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-deploy-pr-deploy-tre

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 22, 2026

What is being addressed

Deploy PR / Deploy TRE can fail during deploy-core when Terraform replaces the Nexus private DNS zone. Azure rejects deletion with 409 CannotDeleteResource if workspace-created virtualNetworkLinks still exist under that zone.

How is this addressed

  • Terraform lifecycle behavior for Nexus DNS zone

    • Updated core/terraform/dns_zones_non_core.tf to allow deleting the zone with child links during replacement.
    • This prevents deployment failure when the Nexus zone must be recreated (for example, when its computed name changes with app gateway FQDN updates).
  • Change applied

    resource "azurerm_private_dns_zone" "nexus" {
      name                = "nexus-${module.appgateway.app_gateway_fqdn}"
      resource_group_name = azurerm_resource_group.core.name
      force_destroy       = true
      tags                = local.tre_core_tags
    
      lifecycle { ignore_changes = [tags] }
    }
  • Pending work

    • None identified for this fix.
  • Documentation

    • No documentation updates required.
  • CHANGELOG / template version

    • Not updated; no user-facing feature or template contract change.

Copilot AI changed the title [WIP] Fix failing GitHub Actions job Deploy PR / Deploy TRE Handle Nexus private DNS zone replacement in Deploy TRE workflow May 22, 2026
Copilot AI requested a review from rudolphjacksonm May 22, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants