Enhance address space handling to accept numeric CIDR masks#4734
Open
JC-wk wants to merge 19 commits into
Open
Enhance address space handling to accept numeric CIDR masks#4734JC-wk wants to merge 19 commits into
JC-wk wants to merge 19 commits into
Conversation
…e documentation accordingly
Unit Test Results677 tests 677 ✅ 8s ⏱️ Results for commit 64afc10. ♻️ This comment has been updated with latest results. |
added 3 commits
October 27, 2025 19:25
Collaborator
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the API for requesting auto-assigned address spaces using numeric CIDR prefix lengths (as strings), extending beyond the existing small/medium/large presets while keeping backwards compatibility.
Changes:
- Extend address space allocation logic to accept numeric CIDR masks (string values) and validate allowed ranges.
- Add repository tests for numeric CIDR prefix requests.
- Update workspace authoring documentation and the project changelog to describe the new behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/tre-workspace-authors/authoring-workspace-templates.md | Documents numeric CIDR mask support for address_space_size when requesting additional address spaces. |
| CHANGELOG.md | Records the enhancement in the unreleased changelog. |
| api_app/tests_ma/test_db/test_repositories/test_workpaces_repository.py | Adds tests covering successful numeric CIDR prefix requests. |
| api_app/models/schemas/workspace_template.py | Updates sample schema description text to mention numeric CIDR masks. |
| api_app/db/repositories/workspaces.py | Implements numeric CIDR prefix parsing/validation and routes it into new CIDR allocation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #4733
What is being addressed
Describe the current behavior you are modifying. Please also remember to update any impacted documentation.
How is this addressed