fix: fall back when mutool fails instead of returning empty HTML - #272
Merged
Conversation
PDF conversion had no try/catch (unlike pandoc after #265). A mutool throw after a successful fetch escaped into fetch's outer catch, which returned html:'' with no statusCode/headers — a blank success shell. Catch mutool failures (and empty output), log them, and fall through to the raw body path so the successful response is preserved. Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>
The fallback path decoded the entire PDF buffer through toEncode, but addBody drops non-media, non-JSON bodies, so the result was discarded. A 20MB PDF with a failing mutool spent 7.5s producing a 190-char document. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017693rzpJsPgMSn8xPq3pz2
Kikobeats
marked this pull request as ready for review
August 7, 2026 07:43
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017693rzpJsPgMSn8xPq3pz2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
When
mutoolthrows after a successful PDF fetch,getHTMLreturnedhtml: ''with nostatusCode/headers — a blank “success” shell. Same failure class as the pandoc empty/error path fixed in #265.Root cause
The PDF/
mutoolbranch insrc/index.jshad no try/catch. A conversion throw escaped intofetch’s outer catch, which intentionally returns an empty body for network failures.Fix
Catch mutool failures (and empty conversion output), log
mutool:error/mutool:empty, and fall through to the raw-body path so the successful HTTP response is preserved.Validation
falls back when mutool throws after a successful fetch(local PDF fixture + rejecting mutool →statusCode: 200, non-empty html).npx ava test/pdf.js -m 'falls back when mutool throws*'passed.