build: upgrade html-urls to ~2.5.0 - #270
Merged
Merged
Conversation
2.5.0 stops `mailto:user@host` being rewritten into a fetchable `http://host`, by way of @metascraper/helpers 5.53.0. Only `TAGS` is consumed here (src/html.js), and 2.5.0 ships no source change at all, so the tag map is identical. The upgrade is inert for this package beyond carrying the fix to anything resolving html-urls through it.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesDependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up html-urls 2.5.0, which stops
mailto:user@hostbeing rewritten into a fetchablehttp://host(via@metascraper/helpers5.53.0).Only
TAGSis consumed here (src/html.js:6), and 2.5.0 ships no source change at all, so the tag map is identical. The upgrade is inert for this package beyond carrying the fix to anything resolving html-urls through it.115 tests passing, lint clean.
Note
Low Risk
Single dependency version bump with no local code changes; intended behavior for
html-getis unchanged aside from transitive URL-handling fixes.Overview
Dependency-only change:
html-urlsis upgraded from~2.4.67to~2.5.0inpackage.json; there are no application code changes in this repo.This package only imports
TAGSfromhtml-urls(used inrewriteHtmlUrlsinsrc/html.js). The release is described as unchanged for that API, so behavior here should stay the same while the newer version carries upstream fixes (notably avoiding incorrect rewriting ofmailto:user@hostintohttp://hostvia updated@metascraper/helpersin the dependency tree).Reviewed by Cursor Bugbot for commit 9f19025. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit