Skip to content

build: upgrade html-urls to ~2.5.0 - #270

Merged
Kikobeats merged 1 commit into
masterfrom
upgrade-html-urls
Jul 30, 2026
Merged

build: upgrade html-urls to ~2.5.0#270
Kikobeats merged 1 commit into
masterfrom
upgrade-html-urls

Conversation

@Kikobeats

@Kikobeats Kikobeats commented Jul 30, 2026

Copy link
Copy Markdown
Member

Picks up html-urls 2.5.0, which stops mailto:user@host being rewritten into a fetchable http://host (via @metascraper/helpers 5.53.0).

Only TAGS is consumed here (src/html.js:6), and 2.5.0 ships no source change at all, so the tag map is identical. The upgrade is inert for this package beyond carrying the fix to anything resolving html-urls through it.

115 tests passing, lint clean.


Note

Low Risk
Single dependency version bump with no local code changes; intended behavior for html-get is unchanged aside from transitive URL-handling fixes.

Overview
Dependency-only change: html-urls is upgraded from ~2.4.67 to ~2.5.0 in package.json; there are no application code changes in this repo.

This package only imports TAGS from html-urls (used in rewriteHtmlUrls in src/html.js). The release is described as unchanged for that API, so behavior here should stay the same while the newer version carries upstream fixes (notably avoiding incorrect rewriting of mailto:user@host into http://host via updated @metascraper/helpers in the dependency tree).

Reviewed by Cursor Bugbot for commit 9f19025. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Chores
    • Updated the underlying HTML URL processing dependency to a newer compatible version.

2.5.0 stops `mailto:user@host` being rewritten into a fetchable `http://host`,
by way of @metascraper/helpers 5.53.0.

Only `TAGS` is consumed here (src/html.js), and 2.5.0 ships no source change at
all, so the tag map is identical. The upgrade is inert for this package beyond
carrying the fix to anything resolving html-urls through it.
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4df7988c-bd15-4a2e-8ccc-ab8ecb7da362

📥 Commits

Reviewing files that changed from the base of the PR and between 30a66bc and 9f19025.

📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

The html-urls dependency in package.json is updated from ~2.4.67 to ~2.5.0.

Changes

Dependency update

Layer / File(s) Summary
Update html-urls version
package.json
The html-urls dependency range is changed from ~2.4.67 to ~2.5.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: upgrading html-urls to ~2.5.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade-html-urls

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Kikobeats
Kikobeats merged commit d9f6575 into master Jul 30, 2026
4 checks passed
@Kikobeats
Kikobeats deleted the upgrade-html-urls branch July 30, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant