refactor(cli): improve root command error handling with idiomatic RunE pattern#323
Open
Harishrs2006 wants to merge 1 commit intomicrocks:masterfrom
Open
refactor(cli): improve root command error handling with idiomatic RunE pattern#323Harishrs2006 wants to merge 1 commit intomicrocks:masterfrom
Harishrs2006 wants to merge 1 commit intomicrocks:masterfrom
Conversation
Signed-off-by: Harish R S <harishrs21082006@gmail.com>
3b624f7 to
d74a5f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces an incremental refactor of the CLI command execution model to improve error handling consistency and align with idiomatic Go and Cobra best practices.
The changes focus on migrating the root command from
RuntoRunEand improving error propagation by removing directerrors.CheckError()usage.Key improvements:
RuntoRunEerrors.CheckError()return errorfmt.Errorf("%w")where applicableSilenceErrorsto avoid duplicate Cobra error outputThis refactor does not introduce breaking changes and is designed as a safe incremental improvement to the CLI architecture.
Benefits
os.Exitstyle behavior)Notes:
This is part of an incremental migration strategy. Additional commands will be refactored in subsequent PRs following the same pattern.
Fixes: #322