feat: add --wait flag to block until Microcks is ready after start#311
Open
mugiwaraluffy56 wants to merge 1 commit intomicrocks:masterfrom
Open
feat: add --wait flag to block until Microcks is ready after start#311mugiwaraluffy56 wants to merge 1 commit intomicrocks:masterfrom
mugiwaraluffy56 wants to merge 1 commit intomicrocks:masterfrom
Conversation
Signed-off-by: puneeth_aditya_5656 <myakampuneeth@gmail.com>
mugiwaraluffy56
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #303.
microcks startreturns as soon as the container is created, but the server inside takes a few seconds to initialize. Runningmicrocks importormicrocks testright after start fails with a connection error because the API is not up yet.Adding
--waitmakesmicrocks startblock and pollGET /api/healthon the mapped port until it returns 200, then exit. An optional--wait-timeoutflag (default 30 seconds) controls how long to wait before giving up with an error.This is the same readiness strategy the Microcks Testcontainers module uses internally. It also makes the
--dry-runpath in #255 straightforward to build on top of, since it needs to know when the ephemeral container is ready before importing an artifact.Before (no --wait):
After (with --wait):
Import succeeds after --wait:
Tests cover the happy path, retry-then-succeed, timeout, and URL construction. All existing tests still pass.