Skip to content

Removes [data-focused] styling for Selector - #38

Draft
microbit-grace wants to merge 1 commit into
mainfrom
select-fix
Draft

Removes [data-focused] styling for Selector#38
microbit-grace wants to merge 1 commit into
mainfrom
select-fix

Conversation

@microbit-grace

@microbit-grace microbit-grace commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #35, #39

  • As documented in RAC Select component, using a mouse or keyboard triggers data-focused on the selector. The styling for &[data-focused] in the recipe is what styles the focus ring and so it makes sense to remove it.
  • Keyboard focus is unaffected after removing this style, because styling for &[data-focus-visible] handles the keyboard case. As documented in RAC Select component, [data-focus-visible] is used when select is specifically keyboard focused.
  • Despite what the comment says, removing styling doesn't seem to change the behaviour of the ComboBox.

@microbit-grace microbit-grace changed the title Remove &[data-focused] style Removes [data-focused] styling for Selector Aug 3, 2026
@microbit-grace
microbit-grace marked this pull request as draft August 3, 2026 16:18
@microbit-grace

Copy link
Copy Markdown
Contributor Author

Going to fix #39 here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-native select has visible focus indicator after mouse selection

1 participant