Select: stop capped dropdowns overflowing their card - #37
Merged
Conversation
RAC writes the maxHeight prop as an inline max-height on the popover, a border-box measure that includes the card's padding and border. The list inherited that same value, so it overshot the inner box and rows spilled past the rounded bottom edge. Size it with flex instead. Fixes the ComboBox equivalent too, since the slots are shared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RAC writes the maxHeight prop as an inline max-height on the popover, a border-box measure that includes the card's padding and border. The list inherited that same value, so it overshot the inner box and rows spilled past the rounded bottom edge. Size it with flex instead. Fixes the ComboBox equivalent too, since the slots are shared.
Closes #34