Conversation
TODO: Fix the AmpliPi spec generation to make these examples valid
This reverts commit 5f13460.
Author
|
@SteveMicroNova can you check to see that these tests make sense? I didn't want to release them with the last changes for simplicity but they provide some decent protection going forward. |
Author
|
There are a lot of changes here, so it probably makes sense to look through them commit by commit since they are organized as a stack of changes. |
|
I've removed the changes I made to the |
| def create_dynamic_tests(): | ||
| """ Generated the test set from the OpenAPI specifications""" | ||
| spec_paths = [ | ||
| 'specs/0.4.5.yaml' |
There was a problem hiding this comment.
this is related to why tests are passing regardless of 0.4.6 state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests for the AmpliPi client validating them against the latest AmpliPi API spec.