Skip to content

Fix plugin autoclose unused import - #4168

Open
usfbih8u wants to merge 1 commit into
micro-editor:masterfrom
usfbih8u:fix_plugin_autoclose_unused_import
Open

Fix plugin autoclose unused import#4168
usfbih8u wants to merge 1 commit into
micro-editor:masterfrom
usfbih8u:fix_plugin_autoclose_unused_import

Conversation

@usfbih8u

@usfbih8u usfbih8u commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@JoeKar JoeKar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop 028ff6f, because for builtin plugins we agreed to stay at v1.0.0.
The version isn't printed anyway:

} else if p.Pack().Builtin {
fmt.Fprintf(out, "%s (built-in)\n", p.Pack().Name)
} else {
fmt.Fprintf(out, "%s (%s)\n", p.Pack().Name, p.Version)
}

@usfbih8u
usfbih8u force-pushed the fix_plugin_autoclose_unused_import branch from 028ff6f to 5dba61b Compare August 9, 2026 16:09
@usfbih8u

usfbih8u commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

You can drop 028ff6f, because for builtin plugins we agreed to stay at v1.0.0.

I think this comes from this text:

"Right now the version number of internal plugins is somehow useless, since we never update them and so they become superfluous."^[https://github.com//pull/3810#issuecomment-3097640920] ~ Jöran Karl 3951388+JoeKar@users.noreply.github.com

A comment like this:

VERSION = "1.0.0" -- all built-in plugins fixed to 1.0.0

in all the plugins would be useful to reflect that policy in the code; in the future, we can change it.

I could make a PR with the changes, but I’d like you to give me the reasoning to include in the commit body so the commit history reflects why that decision was made.

Maybe the previous quote is enough. Your call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants