Fix timeout for no metadata run session (backport #305) - #340
Merged
Merged
Conversation
* Run session if any session is present Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Fix var type Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Modify timeout approach Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Modify wait approach Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Add tests for 'rmw_wait' Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix possible segfault Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Add CI workflow step Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix CI after new step Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> --------- Signed-off-by: acuadros95 <acuadros1995@gmail.com> Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> Co-authored-by: David Laseca Perez <davidlaseca@eprosima.com> (cherry picked from commit 938801c)
Contributor
Author
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## kilted #340 +/- ##
==========================================
- Coverage 55.46% 54.60% -0.87%
==========================================
Files 102 101 -1
Lines 6070 5897 -173
Branches 997 940 -57
==========================================
- Hits 3367 3220 -147
+ Misses 2352 2344 -8
+ Partials 351 333 -18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spin is not waiting if a session only haves timers, ending in a 100% CPU usage with code like this one: int32_publisher.
Also, we should run all sessions atleast once, to ensure a response to incoming data (From Hard liveliness check for example).
Related issue: #297
This is an automatic backport of pull request #305 done by Mergify.