fix: apply paths.exclude during skill discovery#28
Open
cidrblock wants to merge 1 commit into
Open
Conversation
[paths].exclude and --exclude were parsed and documented but never used, so discovery walked the whole tree (including .tox/site-packages) and failed E013 on third-party SKILL.md files. Filter discovery with globset and skip matching subtrees.
Merged
3 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[paths].exclude/--excludewere parsed and documented but never applied during discoveryglobset, skips matching subtrees (e.g..tox/), and omits skills under excluded pathsSKILL.mdunder.tox/site-packages(Playwright, etc.)Attribution
Human lead, AI assisted (Grok)
Test plan
cargo testtest_discover_skills_respects_excludetest_check_exclude_skips_nested_skills.skillmark.tomlwithexclude = [".tox/"]no longer reports Playwright skills when run from a repo with a populated.tox