Repository navigation
Add generation-safe local management for warm workers - #5
Merged
Merged
Conversation
michaelishri
marked this pull request as ready for review
September 25, 2026 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warm credential workers need targeted cancellation that preserves idle siblings and cannot let an old request stop a replacement. This adds opt-in Unix management protocol v1 with private same-UID sockets, random per-launch generations, conditional restart and confirmed process-group cleanup before replacement. Clean recycling is opt-in through
restartOnSuccess;clearEnvsupplies an explicit child environment. Controllable targets must be configured, noncritical and automatically restarted.The branch incorporates audited main
d9ad573(Gonner v0.1.0) and resolves the lifecycle overlap through the shared execution service. Each launch receives its own restart-request channel and grace period; exact child waiting, stable initial readiness, secure credentials/log handling, signal-error propagation and bounded output drainage are preserved. Normal shutdown retains the configured global/process grace. The audited Go 1.26.7 and x/sys v0.48.0 pins remain unchanged. Seedocs/management.md.Validation at
6cb05577ca71f4c930544b797da63e4bfcb0d565: GitHub CI covers Linux and macOS module/format/build/vet/race tests, Python release-tool tests, Linux PID-1/capability integration, and source plus all four release-binary vulnerability scans. Local checks also passed. New integration coverage exercises targeted grace, confirmed forced-descendant reaping, sibling preservation and stale-generation rejection with Gonner running as container PID 1. Local qualification containers were removed after testing.The helper implementation, including merged PR #4, separately passed its full Jenkins qualification, including native amd64 lifecycle and approved emulated ARM64 compatibility. Those release fixtures use the explicitly qualified ancestor pin
ca6caedd4c869c92de2ef2bd4942ea09a23fae44; updating the helper's supervisor pin requires its own compatibility run. This PR does not silently change an existing consumer pin.Tracks POC-446/450 and 1PA-2. No release publication, service deployment or live credential acceptance is included.