Repository navigation
fix: honor graceful shutdown and release v0.0.3 - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIGTERM/SIGINT previously cancelled
exec.CommandContext, immediately killing the directly launched process before graceful shutdown ran. This skipped service cleanup when usingexecand could leave a child running when launched through a shell.Commands now send the configured stop signal to their original process group, wait for the configured timeout, and escalate to SIGKILL for remaining members even after the shell exits. The same lifecycle applies to startup commands and descendants left after normal command exits. Sequential startup waits for shutdown to finish; shutdown status and startup log cleanup now follow that lifecycle.
Adds nine isolated Linux regression cases, updates the shutdown documentation, and adds the v0.0.3 changelog. The existing release workflow will publish the patch release with all four platform binaries and checksums after merge.
Validation:
go test ./... -race -covergo vet ./...GOOS=darwin GOARCH=arm64 CGO_ENABLED=0 go build ./...execand shell-wrapped commands now complete graceful shutdown without surviving children.