Update thumbTouchSize adjustment for trackClickable={false} - #458
Open
elliottkember wants to merge 1 commit into
Open
Update thumbTouchSize adjustment for trackClickable={false}#458elliottkember wants to merge 1 commit into
elliottkember wants to merge 1 commit into
Conversation
Fixes an issue where if trackClickable is set to false, the adjustments for _previousLeft are not applied correctly and the scrubber jumps slightly if the thumbTouchSize is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where if trackClickable is set to false, the adjustments for _previousLeft are not applied correctly and the scrubber jumps slightly if the thumbTouchSize is set.
I fixed this issue originally, but I only just set
trackClickable={false}today. I noticed that the scrubber was jumping again. I don't know why these two properties would interact like this but I sense it has something to do with the dragging event triggering on the track rather than on the scrubber.Either way, this fixes the issue very nicely.
Snack: https://snack.expo.dev/@elliottkember/@miblanchard-react-native-slider