Adding new kgo for uv_index acceptance test. - #132
Merged
Merged
Conversation
mo-kbogue
previously approved these changes
Jun 17, 2026
mo-kbogue
left a comment
mo-kbogue
left a comment
There was a problem hiding this comment.
Ran acceptance test using this kgo and can't see any problems.
2 tasks done
maxwhitemet
previously approved these changes
Sep 28, 2026
maxwhitemet
left a comment
maxwhitemet
left a comment
Contributor
There was a problem hiding this comment.
Thanks @mo-jbeaver. I'm happy with the new kgo data. I have suggested a minor change but it's not required.
Contributor
There was a problem hiding this comment.
Suggestion: When the KGO file lives in a self-describing directory, we call this 'kgo.nc' instead. This would further require you modifying the kgo path in the acceptance test script and running the recreate checksums command.
mo-jbeaver
dismissed stale reviews from maxwhitemet and mo-kbogue
via
September 28, 2026 13:03
d20be73
maxwhitemet
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to:
Issue - https://github.com/metoppv/mo-blue-team/issues/1151
PR - metoppv/improver#2374
Adding an additional directory and KGO for a non-default scale factor.