Fix transition pair absence - #2457
Merged
gavinevans merged 6 commits intoOct 2, 2026
Merged
Conversation
mo-jbeaver
requested changes
Oct 1, 2026
Contributor
There was a problem hiding this comment.
I've added some comments below, but all tests ran successfully.
Additionally, is there a fall back for it source_b isn't available and we can't default back to source_a as it is not available anymore (i.e. If it doesn't produce forecasts at that lead time.)?
maxwhitemet
previously approved these changes
Oct 1, 2026
maxwhitemet
left a comment
Contributor
There was a problem hiding this comment.
Happy with the changes made. Approved 👍
mo-jbeaver
requested changes
Oct 2, 2026
mo-jbeaver
left a comment
Contributor
There was a problem hiding this comment.
Added a few more questions below for some clarification, but all the tests passed successfully.
mo-jbeaver
approved these changes
Oct 2, 2026
mo-jbeaver
left a comment
Contributor
There was a problem hiding this comment.
Happy with all the changes, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/metoppv/mo-blue-team/issues/1293
Description
This PR addressed a minor issue that can occur in spin-up where the inputs for a specified transition in the SpatialMorphing plugin are both absent. For example, if the transitions dictionary is defined as below, but only source_c is available, the SpatialMorphing plugin will currently fail, as a transition is defined, but neither of the source pair is available. This PR adds more leniency, so that if source_a and source_b are both absent then the plugin will fallback to source_c.
Testing: