Repository navigation
fix(agent-context): tighten metaobjects-audit drift, status-guard and eject-history checks - #551
Merged
Merged
Conversation
…d check, stale-copy and include-only fixes Four fixes from the audit skill's first run on an adopter project: - drift signature 13: an enum member or event name typed as a hand string beside the generated constant - axis G3: every write to a status-like enum column is conditional on the current value; the fix uses the port's ORM with generated constants, never raw SQL - an owned generator copy with lines of its own is not proof of a customization: DIFFERS also marks a copy stale by version, so check history and report lines behind and lines of the project's own separately - exempt include-only templates from the byte-identical template duplication rule Per-port files and the regenerated agent-context conformance goldens updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
drift-signatures.md): an enum member or event name typed as a hand string beside the generated constant is drift. Calibration exempts literals at positions the type checker already verifies. AddsG3tosurface-review-axes.md, which requires every write to a status-like enum column to be conditional on the current value, with the fix going through the port's ORM and generated constants, never raw SQL.SKILL.md, owned-generator check): a copy with lines of its own no longer counts as customized. The history check now runs on everyDIFFERSrow, and the report separates lines behind the reference from lines of the project's own. A copy stale by version is reported asowned-generator-stale.prompt-anti-patterns.mdandcalibration.md: include-only templates (bodies that are only{{> partial }}includes) are exempt from the byte-identical template-duplication finding.typescript,java,kotlin,python,csharp) and theagent-context-conformanceexpected fixtures.Validation
Risk Assessment
✅ Low: Docs-only edits to the audit skill and its byte-identical conformance fixture copies. All four feedback items are implemented as the intent requires, and I found no contradictions or defects.
Testing
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
⏭️ **Test** - skipped
Step was skipped.
⏭️ **Document** - skipped
Step was skipped.
⏭️ **Lint** - skipped
Step was skipped.
✅ **Push** - passed
✅ No issues found.