Repository navigation
feat(agent-context): make metaobjects-audit check gate blocking and bypassed codegen - #550
Merged
Merged
Conversation
…d that adopted artifacts are used The metaobjects-audit skill asked whether a verify gate was wired, never whether it blocked, and it did not join unused generated artifacts to the hand-written pages that replaced them. Add the checks and the remedy for each gap: - Axis F: does the gate block (exit code propagates, green now with a ratchet for a tolerated count, every deploy path passes it); score BLOCKING / RUNS BUT DOES NOT BLOCK / ABSENT; no CI is NO whatever untracked hooks exist, with a per-port snippet. - Axis F2: consumed / emitted per generator kind, and a generated-and-bypassed finding. - Prompts: unlinked payload fields, linked / (linked + unlinked copies). - Requirements: ledger staleness from git, --require-implementers, unwired implementers. - Owned-copy check in the Java, Kotlin, C# and Python references, one total. - Phase 1b shape-coverage census; scorecard 'used as described' line; re-runs mark earlier findings fixed / open / deferred; JSON top-level fields documented. Conformance fixture copies of the skill are updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
consumed / emittedper generator kind and agenerated-and-bypassedfinding for hand-built pages beside unused generated ones.extends: Entity.fieldvs free-standing copies), three ledger currency checks (staleness from git history,--require-implementers, unwired live implementers), and a shape-coverage census in Phase 1b. The report gains a "Used as described" line and re-runs compare against.metaobjects/adoption-audit.jsonwith fixed, open, deferred and new statuses.fixtures/agent-context-conformance/*/expected/copies are updated to match, and CHANGELOG.md records the change.Validation
Risk Assessment
✅ Low: Docs-only change to the audit skill and its conformance fixtures; every command, flag and output format it cites matches the source, fixtures are identical to the skill sources, and the skill covers each of the seven gaps in the intent.
Testing
Pipeline
Updates from git push no-mistakes
Validated in one no-mistakes run (docs tier: review, push and PR; test, lint, document and CI skipped by triage; CI is local for this repo). Local checks before the run: sdk tests (424 pass) and the
gatessection ofscripts/ci-local.sh.✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
⏭️ **Test** - skipped
Step was skipped.
⏭️ **Document** - skipped
Step was skipped.
⏭️ **Lint** - skipped
Step was skipped.
✅ **Push** - passed
✅ No issues found.