This repository was archived by the owner on Oct 14, 2026. It is now read-only.
Repository navigation
Conversation
|
The deployments were removed when this pull request closed. Reopening it deploys again at the same address. |
tmashara
force-pushed
the
gro-1085-separate-docs-navigation-links-from-expand-and-collapse
branch
from
October 13, 2026 09:26
7569569 to
be8283c
Compare
tmashara
changed the title
tmashara
force-pushed
the
gro-1085-separate-docs-navigation-links-from-expand-and-collapse
branch
from
October 13, 2026 11:32
be8283c to
a83852c
Compare
tmashara
force-pushed
the
gro-1085-separate-docs-navigation-links-from-expand-and-collapse
branch
from
October 13, 2026 11:38
a83852c to
69b10a3
Compare
tmashara
marked this pull request as ready for review
October 13, 2026 12:47
losrebellos
approved these changes
Oct 13, 2026
losrebellos
left a comment
losrebellos
left a comment
Contributor
There was a problem hiding this comment.
Approved with a nit 😅
| <button | ||
| type="button" | ||
| class={selected} | ||
| aria-current={current} |
Contributor
There was a problem hiding this comment.
It might mess the screen readers into showing it as the current page, but it being as toggle instead...
Contributor
Author
There was a problem hiding this comment.
right, deleted aria-current
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tmashara
deleted the
gro-1085-separate-docs-navigation-links-from-expand-and-collapse
branch
October 13, 2026 14:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes GRO-1085
Reverts the parent-link behavior from #1357: clicking a nav item with children only expands/collapses it again
parent rows no longer render an
href, and the whole row (title and chevron) acts as one toggle.website PR: https://github.com/metabase/metabase.github.io/pull/6665
verification
Screen.Recording.2026-10-13.at.13.09.52.mov