Repository navigation
Conversation
AIO_ReadPool_consumeBytes() can advance srcBuffer into coalesceBuffer. A later refill moves the remaining bytes back to the beginning of the same buffer, so memcpy() is undefined when those ranges overlap. Use memmove() for this compaction. A valid 17-byte stream consisting of an empty skippable frame and an empty zstd frame reproduces a 9-byte copy from coalesceBuffer + 8 under ASan. Add a CLI regression covering test and decompression modes with async I/O enabled and disabled. Require successful decoding and empty output so sanitizer failures cannot pass as expected input errors.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIO_ReadPool_consumeBytes() can advance srcBuffer into coalesceBuffer. A later refill moves the remaining bytes back to the beginning of the same buffer, so memcpy() is undefined when those ranges overlap.
Use memmove() for this compaction. A valid 17-byte stream consisting of an empty skippable frame and an empty zstd frame reproduces a 9-byte copy from coalesceBuffer + 8 under ASan.
Add a CLI regression covering test and decompression modes with async I/O enabled and disabled. Require successful decoding and empty output so sanitizer failures cannot pass as expected input errors.