Add LoRa FEM LNA toggle menu support - #11341
Conversation
⚡ Try this PR in the Web FlasherNote Building this pull request… the flash button, badges and supported-board |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesLoRa FEM LNA menu
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant User
participant menuHandler
participant LoRaFEMInterface
participant DeviceConfiguration
participant Logger
User->>menuHandler: Select FEM LNA mode
menuHandler->>LoRaFEMInterface: Update and apply LNA state
menuHandler->>DeviceConfiguration: Reload configuration
menuHandler->>Logger: Log FEM LNA state
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello The main problem is the Heltec V4.2 is still not working well even with 2.7.26: Thanks |
fb17f6d
Summary
Adds an on-device screen menu for controlling the LoRa FEM LNA using the existing
fem_lna_modeconfiguration.This restores the screen control that was removed from #9753 without changing the protobuf definition, FEM driver, or default LNA behavior.
Changes
FEM LNAto the on-device LoRa Actions menu.EnabledandDisabledselections and highlights the current setting.🤝 Attestations
Hardware testing is still required before these attestations can be checked.
Summary by CodeRabbit