Conversation
9 tasks
Komzpa
force-pushed
the
codex/split-sim-determinism-cleanup
branch
6 times, most recently
from
May 5, 2026 20:17
0983516 to
9cba694
Compare
Komzpa
force-pushed
the
codex/split-sim-determinism-cleanup
branch
from
May 6, 2026 07:06
9cba694 to
06ad4ea
Compare
Komzpa
force-pushed
the
codex/split-sim-determinism-cleanup
branch
3 times, most recently
from
May 15, 2026 21:01
cf99213 to
f72b56b
Compare
7 tasks
Komzpa
marked this pull request as ready for review
May 17, 2026 17:24
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f72b56b3dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Komzpa
marked this pull request as draft
May 17, 2026 17:41
Signed-off-by: Darafei Praliaskouski <me@komzpa.net>
- treat unparsable map altitude values as absent instead of failing the whole import with an uncaught TypeError/ValueError - import CLIENT_BASE nodes on the router side: current firmware rebroadcasts them like ROUTER_LATE - compare the trig-derived origin longitude with a tolerance in tests
A present origin block that is not a map or lacks a usable lat/lon pair now raises instead of silently dropping the origin and projecting terrain against a different origin than the author intended. Accept the latitude/longitude key spellings alongside lat/lon.
Concurrent runs sharing one cache directory wrote the same fixed temp filename and could atomically publish an interleaved, corrupt tile that then stayed cached. Download and unpack through process-unique temp names and clean up archives after unpacking.
Cache keys carried id(TERRAIN_GRID), so a reused object address after a Config-reusing parse could serve losses computed against an earlier grid. Key the cache on a monotonically increasing per-grid token instead. Also pick the nearest interpolation samples with heapq.nsmallest instead of sorting every sample in this hot path, and use the shared node_antenna_height helper from lib.common instead of a diverging local copy.
Automatic SRTM tile selection evaluated the full link budget for every node pair. Derive one conservative best-case link distance (path loss grows monotonically with distance in every lib.phy model) and skip pairs beyond it before the expensive per-pair work; document that the selection scales with node pairs and recommend --map-limit for broad imports. Also log when a wrapped --map-bbox is discarded for terrain so the substituted extent is not silent, and import node_antenna_height from its canonical module.
TCPInterface connects without a socket timeout, so a stale --nodedb-host blocked the CLI indefinitely. Probe reachability with a bounded connect first so unreachable hosts fail fast with the existing could-not-connect error.
Komzpa
force-pushed
the
codex/split-sim-determinism-cleanup
branch
from
August 21, 2026 00:30
2f49dd7 to
6f7d86f
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Komzpa
force-pushed
the
codex/split-sim-determinism-cleanup
branch
from
August 21, 2026 00:57
6f7d86f to
80264ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yaml.safe_loadand remove small import/string cleanupsloraMesh.pyruns when those models are enabledStack
fix(sim): make radio comparisons reproducible).Validation
.venv/bin/python -u loraMesh.py 2 --no-gui --simtime-seconds 2 --period-seconds 1 --phy-loss-model --capture-collision-model.venv/bin/python -m unittest tests.test_lora_mesh_cli tests.test_node tests.test_phy tests.test_radio_policy_compare/home/kom/.local/bin/ruff check batchSim.py lib/interactive.py lib/node.py loraMesh.py tests/test_node.py tests/test_phy.py.venv/bin/python -m compileall -q ..venv/bin/python tools/radio_policy_compare.py --simtime-seconds 5 --period-seconds 2 --policies static,dcr,dcr_dtp -- --no-clutter.venv/bin/python -m unittest(134 tests)git diff --check