Extend WiFi disconnect logging to specify reason - #3382
Open
Blake-Latchford wants to merge 1 commit into
Open
Conversation
# What is the problem? Today if a user builds firmware with an incorrect WiFi SSID or password, they get a generic `WiFi disconnected.` error message. # What is the solution? Extend logging to descirbe the reason that WiFi was disconnected. # Testing Done I gathered the updated logs for the 3 scenarios below. ## Provided an incorrect password ``` WiFi: Attempting manual WiFi reconnect... WiFi: WiFi disconnected (reason=ASSOC_LEAVE). Flagging for reconnect... WiFi: WiFi disconnected (reason=4WAY_HANDSHAKE_TIMEOUT). Flagging for reconnect... WiFi: WiFi disconnected (reason=4WAY_HANDSHAKE_TIMEOUT). Flagging for reconnect... WiFi: WiFi disconnected (reason=4WAY_HANDSHAKE_TIMEOUT). Flagging for reconnect... ``` ## Provided an incorrect SSID ``` WiFi: WiFi disconnected (reason=NO_AP_FOUND). Flagging for reconnect... ``` ## Provided correct SSID & password ``` WiFi: WiFi connected successfully! WiFi: Got connection ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem?
Today if a user builds firmware with an incorrect WiFi SSID or password, they get a generic
WiFi disconnected.error message.What is the solution?
Extend logging to descirbe the reason that WiFi was disconnected.
Testing Done
I gathered the updated logs for the 3 scenarios below.
Provided an incorrect password
Provided an incorrect SSID
Provided correct SSID & password