Skip to content

feature/hub ref improvement#174

Open
JohannesRudolph wants to merge 3 commits into
mainfrom
feature/hub_ref_improvement
Open

feature/hub ref improvement#174
JohannesRudolph wants to merge 3 commits into
mainfrom
feature/hub_ref_improvement

Conversation

@JohannesRudolph
Copy link
Copy Markdown
Member

@JohannesRudolph JohannesRudolph commented May 19, 2026

  • refactor: use var.hub.git_ref for backplane sources, add const=true
  • chore: remove update-module-refs tool

@JohannesRudolph
refactor: use var.hub.git_ref for backplane sources, add const=true
432850f 
- Replace all hardcoded commit SHA refs in backplane module sources with
  ${var.hub.git_ref}, making the update-module-refs tool obsolete
- Add `const = true` to all `variable "hub"` blocks so OpenTofu/Terraform
  can resolve var.hub.git_ref at init time (requires OpenTofu >= 1.12)
- Add/update required_version = ">= 1.12.0" in all meshstack_integration.tf
  terraform blocks
- Update copilot-instructions.md baseline from >= 1.11.0 to >= 1.12.0
@JohannesRudolph
chore: remove update-module-refs tool
e83f6e8 
Superseded by const variable support in OpenTofu >= 1.12 / Terraform >= 1.15.
Backplane module sources now use var.hub.git_ref which is resolved at init time,
so there is no longer any need to stamp hardcoded commit SHAs.
@JohannesRudolph JohannesRudolph requested a review from grubmeshi May 19, 2026 12:42
@JohannesRudolph
chore: remove update-module-refs GHA workflow
04b95e7 
The workflow is no longer needed since the tool was removed.
@JohannesRudolph
Copy link
Copy Markdown
Member Author

JohannesRudolph commented May 19, 2026

@grubmeshi fyi post-factum

I have found a simpler way to maintain hub references and pin versions between backends and terraform implementations correctly rather than using the custom tool. We have supported a hub.git_ref variable already, and re-using this for the backend module source makes our versioning approach simpler overall:

Superseded by const variable support in OpenTofu >= 1.12 / Terraform >= 1.15.
Backplane module sources now use var.hub.git_ref which is resolved at init time,
so there is no longer any need to stamp hardcoded commit SHAs.

@aws-amplify-eu-central-1
Copy link
Copy Markdown

aws-amplify-eu-central-1 Bot commented May 19, 2026

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-174.d1o16zfeoh2slu.amplifyapp.com

@JohannesRudolph
Copy link
Copy Markdown
Member Author

JohannesRudolph commented May 19, 2026

Note: we'll have to wait until opentofu 1.12 lands in nixos before we can start testing this change properly in CI (don't forget to update flake.lock)

Until then we need to keep this PR open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grubmeshi grubmeshi Awaiting requested review from grubmeshi

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JohannesRudolph