Provide texture "crawl" feature#198
Open
SeanCurtis-TRI wants to merge 1 commit into
Open
Conversation
SeanCurtis-TRI
commented
May 19, 2026
Contributor
Author
SeanCurtis-TRI
left a comment
SeanCurtis-TRI
left a comment
There was a problem hiding this comment.
+a:@jwnimmer-tri for review, please.
@SeanCurtis-TRI made 1 comment.
Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on jwnimmer-tri).
This is direct support of Drake's surface velocity implementation in which the surface of an object exhibits motion independent of the body's motion. This implementation works by assigning novel properties to the appropriate materials (to provide uniform parameters to the shader). This required *deferred* evaluation of set_property(). For objects loaded asynchronously, a common sequence of of set_object() and set_property() calls would cause the property to be erased. Now, the call to set_property() is saved to be applied after the object is successfully loaded. Add pending_properties to set_property_chain
SeanCurtis-TRI
force-pushed
the
PR_crawling_texture
branch
from
96cd7eb to
d0f1563
Compare
Contributor
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Per f2f this is basically on the right track.
However, I'm going to let the other two meshcat PRs merge first (embedded images, properties queue) and they cycle back here to review just the new protocol part by itself.
@jwnimmer-tri made 1 comment.
Reviewable status: 0 of 9 files reviewed, all discussions resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is direct support of Drake's surface velocity implementation in which the surface of an object exhibits motion independent of the body's motion.
This implementation works by assigning novel properties to the appropriate materials (to provide uniform parameters to the shader). This required deferred evaluation of set_property(). For objects loaded asynchronously, a common sequence of of set_object() and set_property() calls would cause the property to be erased. Now, the call to set_property() is saved to be applied after the object is successfully loaded.
This change is