⚡ Bolt: [Cache Printify variants to prevent N+1 bottleneck]#57
Conversation
Memoizes `get_variants` using `@functools.lru_cache` and returns an immutable tuple across `printify_manager.py`, `merch_factory.py`, and `create_merch.py`. This prevents duplicate network requests for static blueprint data during bulk creation loops. Co-authored-by: merg357 <221854052+merg357@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
@functools.lru_cachetoget_variantsinprintify_manager.py,merch_factory.py, andcreate_merch.py. Changed the return type from a mutablelistto an immutabletupleto ensure thread safety and prevent downstream mutations when retrieving cached data.json.dumps()securely and natively serializes tuples into JSON arrays, meaning no payload changes were required.🎯 Why: During bulk product creation, the
get_variantsfunction is called for every single item created, but the returned variant data for a givenblueprint_idandprint_provider_idis static. This was creating an N+1 network bottleneck on the Printify API.📊 Impact: Eliminates redundant network requests, reducing the number of Printify API calls by thousands for large bulk merchandise creation runs, drastically speeding up execution.
🔬 Measurement: Validated via
python3 -m py_compile *.py. The improvement can be verified by running any bulk creation command (e.g.,python3 printify_manager.py run) with a large set of images and comparing execution times and network traffic logs.PR created automatically by Jules for task 11810593196451402024 started by @merg357