test: assert the fastify 5 plugin dependency error - #136
Open
mikaelkaron wants to merge 1 commit into
Open
Conversation
`registration - should error if mercurius is not loaded` expected the `AssertionError` fastify 4 raised for an unmet plugin dependency. Fastify 5 raises a `FastifyError` coded `FST_ERR_PLUGIN_DEPENDENCY_NOT_REGISTERED` instead, so the assertion has failed since the move to fastify 5 and `npm test` does not pass on main. The test now asserts that code and the message. It also gets a `t.plan`, without which the assertion in the `catch` is skipped entirely — and the test passes — whenever registration does not throw, which is the failure mode this test exists to catch. Signed-off-by: Mikael Karon <mikael@karon.se>
This was referenced Jul 27, 2026
Author
|
@mcollina bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm testdoes not pass onmain:registration - should error if mercurius is not loadedstill expects theAssertionErrorthat fastify 4 raised for an unmet plugin dependency.Fastify 5 raises a
FastifyErrorcodedFST_ERR_PLUGIN_DEPENDENCY_NOT_REGISTERED, so the test asserts that code and the message instead.It also gets a
t.plan. Without one, the assertion inside thecatchis skipped — and the test passes — whenever registration does not throw at all, which is precisely the regression this test exists to catch.Verification
npm testpasses: lint, 123 tests with 2 skipped,tstyche47 assertions.