Skip to content

fix: support patchwork >= 1.3 in build_patchwork() - #20

Merged
mengxu98 merged 1 commit into
mainfrom
fix/patchwork-1.3-build-patchwork
Sep 10, 2026
Merged

mengxu98 merged 1 commit into
mainfrom
fix/patchwork-1.3-build-patchwork

Conversation

@mengxu98

Copy link
Copy Markdown
Owner

build_patchwork() is a fork of patchwork's assembly. patchwork 1.3 moved the pieces into x$patches (with one plot held by the object itself) and changed the internals, so the function failed with object of type 'environment' is not subsettable.

The fork now follows the current internals (collected axes and axis titles, guide position, panel-area, background z-order) and normalises the input through patchwork's own get_patches(), so both patchwork objects and patches lists work. The table geometry arguments are set by patchwork itself and now warn instead of building an invalid table.

Verified against patchwork 1.3.2: the assembled gtable is identical to patchwork::patchworkGrob() (same dimensions, cells, grob names and sizes), and patchwork_grob(), as_gtable(), as_grob() and panel_fix() all work. Adds tests/test-build-patchwork.R.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T10:14:53.069471Z 6fe905d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mengxu98
mengxu98 merged commit c8ec744 into main Sep 10, 2026
7 checks passed
@mengxu98
mengxu98 deleted the fix/patchwork-1.3-build-patchwork branch September 10, 2026 10:13
mengxu98 added a commit that referenced this pull request Sep 15, 2026
fix: support patchwork >= 1.3 in `build_patchwork()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant