Repository navigation
fix: theme must own both light and dark values for every primitive it sets - #9
Merged
Merged
Conversation
… sets The previous commit's explicit @layer ordering fixed the accent-color regression, but introduced a new one: a higher-priority layer beats a lower-priority one regardless of selector specificity, so this file's dark-mode :root values kept beating Starlight's own, lower-priority :root[data-theme='light'] values for every primitive touched here - the light/dark switch broke again, this time for surfaces rather than accent. Also fixes a color-mix() percentage that was backwards (color-mix(in srgb, #ff6b4a 35%, white) mixes 35% orange with 65% white, reading as pale pink rather than a lighter orange - flipped to 80% orange, 20% white). This file now explicitly sets both themes' values for every primitive it touches, copying Starlight's own default light-mode primitives verbatim rather than leaning on its lower-priority layer to supply them. Verified both themes, the search dialog, and the accent color on buttons/links in an actual browser before pushing. Signed-off-by: Lukas Hirt <info@hirt.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two regressions from the previous theme fix, both root-caused and verified in an actual browser this time: