Skip to content

fix: wrap theme overrides in Starlight's cascade layer #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukasHirt merged 1 commit into from
Sep 25, 2026
Merged

fix: wrap theme overrides in Starlight's cascade layer #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 26 additions & 17 deletions src/styles/theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,25 +13,34 @@
* defines those once as `var(--sl-color-black)` etc, so they resolve
* correctly under both themes only if the primitives they reference are
* the ones overridden per theme, not the derived variables themselves.
*
* This must be wrapped in Starlight's own `starlight.base` layer:
* customCss is injected unlayered by default, and unlayered CSS always
* wins over layered CSS regardless of selector specificity - an
* unscoped `:root` here would otherwise beat Starlight's own, more
* specific `:root[data-theme='light']` rule (itself inside this layer),
* breaking the light/dark switch for every property this file touches.
*/

:root {
--sl-color-black: #0a0d10;
--sl-color-white: #e7ecef;
--sl-color-gray-1: #e7ecef;
--sl-color-gray-2: #e7ecef;
--sl-color-gray-3: #8a97a3;
--sl-color-gray-4: #78838d;
--sl-color-gray-5: #232b32;
--sl-color-gray-6: #12171c;
@layer starlight.base {
:root {
--sl-color-black: #0a0d10;
--sl-color-white: #e7ecef;
--sl-color-gray-1: #e7ecef;
--sl-color-gray-2: #e7ecef;
--sl-color-gray-3: #8a97a3;
--sl-color-gray-4: #78838d;
--sl-color-gray-5: #232b32;
--sl-color-gray-6: #12171c;

--sl-color-accent-low: #7a3b2c;
--sl-color-accent: #ff6b4a;
--sl-color-accent-high: color-mix(in srgb, #ff6b4a 35%, white);
}
--sl-color-accent-low: #7a3b2c;
--sl-color-accent: #ff6b4a;
--sl-color-accent-high: color-mix(in srgb, #ff6b4a 35%, white);
}

:root[data-theme='light'] {
--sl-color-accent-low: hsl(11, 90%, 88%);
--sl-color-accent: hsl(11, 90%, 56%);
--sl-color-accent-high: hsl(11, 80%, 28%);
:root[data-theme='light'] {
--sl-color-accent-low: hsl(11, 90%, 88%);
--sl-color-accent: hsl(11, 90%, 56%);
--sl-color-accent-high: hsl(11, 80%, 28%);
}
}
Loading