Skip to content

healthz: report status and build SHA through meltkit v0.4.1 - #9

Merged
meltforce merged 1 commit into
mainfrom
claude/healthz-build-sha
Nov 13, 2026
Merged

meltforce merged 1 commit into
mainfrom
claude/healthz-build-sha

Conversation

@meltforce

Copy link
Copy Markdown
Owner

Acceptance criteria

  1. GET /healthz on the real listener answers 200, application/json, {"status":"ok","sha":"<full commit SHA>"}; a build without BUILD_SHA reports dev.
  2. deploy.yml, preview.yml, release.yml and scripts/e2e pass BUILD_SHA; /version, the loopback health listener and VERSION are unchanged.

Test per criterion

  1. internal/server/health_test.go, TestHealthzReportsBuildSHA (meltkit v0.4.1 WithBuildSHA).
  2. scripts/e2e (upgrade from and rollback to origin/main); the live /healthz after the deploy.

Test output

--- PASS: TestHealthzReportsBuildSHA (0.00s)
    --- PASS: TestHealthzReportsBuildSHA/pipeline_build (0.00s)
    --- PASS: TestHealthzReportsBuildSHA/local_build (0.00s)
PASS
ok  	github.com/meltforce/vimmary/internal/server	0.013s

lint ok
test ok
e2e ok: 449462340c1f992c7f1547e339cc94f210a2a3d0, upgrade from and rollback to origin/main

Production changes

None

🤖 Generated with Claude Code

GET /healthz on the real listener answers {"status":"ok","sha":"<commit>"}
(homelab STANDARDS.md § Image registry & tagging). meltkit v0.4.1 serves
it; vimmary passes the SHA with WithBuildSHA. The Dockerfile takes
BUILD_SHA into main.BuildSHA, and deploy.yml, preview.yml, release.yml and
scripts/e2e pass it. /version, the loopback health listener and VERSION
are unchanged.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Review: approve

Commit 4494623

The app's main /healthz now answers {"status":"ok","sha":"<commit>"}, with dev for local builds. The change bumps meltkit to v0.4.1 and passes the commit SHA into the build in the deploy, preview and release workflows, the Dockerfile and scripts/e2e. /version, the loopback health listener and VERSION are untouched. The new test TestHealthzReportsBuildSHA checks status, content type and body for both a pipeline SHA and dev. I did not run the tests or the build. I read the diff only. No checks are weakened, nothing is added to startup, and no migrations, secrets or new config keys are involved. Nothing is needed in the homelab repo. One minor point, not a blocker: /healthz on the main listener reports the SHA but does not check the database. /version still does that and remains what the deploy waits on.

@github-actions

Copy link
Copy Markdown

preview: 4494623 is live at https://knox.coydog-fence.ts.net:8091/

@meltforce
meltforce merged commit 5793da2 into main Nov 13, 2026
6 checks passed
@meltforce
meltforce deleted the claude/healthz-build-sha branch November 13, 2026 17:34
@github-actions

Copy link
Copy Markdown

live: 5793da2 is deployed to production (run).

This branch was successfully deployed

1 active deployment
preview — 44946234 Deployed Nov 13, 2026 by meltforce via deploy #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant