Skip to content

fix(scripts): run the check-script contract suite without the caller's CHECK_DATA_ROOT #10598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 2 commits into from
Oct 28, 2026
Merged

fix(scripts): run the check-script contract suite without the caller's CHECK_DATA_ROOT #10598

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6556867
fix(scripts): run the check-script contract suite without the caller'…
kyle-sexton Oct 28, 2026
c226df3
Merge branch 'main' into fix/script-contract-test-data-root
kyle-sexton Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/check-script-contract.test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@
# basename is also what routes a member's changes back here, since
# scripts/affected-tests.sh selects any suite that NAMES the changed file.
set -uo pipefail
# Members read CHECK_DATA_ROOT in place of the tree they are run in, so a
# caller's value would point every fixture run at that caller's tree.
unset CHECK_DATA_ROOT

SELF_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit 2
REPO_ROOT="$(cd "$SELF_DIR/.." && pwd)" || exit 2
Expand Down
Loading