Repository navigation
build: bump zizmorcore/zizmor-action to 0.7.1 - #505
Conversation
Moves the release workflow's zizmor-action pin to v0.7.1 and records the same version and commit in release/dependencies.json, which Dependabot cannot edit (Test-ReleasePins.ps1 requires the two to agree). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VcupojEVPjg9zYgTTu3TNk
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed No findings. The PR bumps
A repo-wide grep found no other references to Not verified by me:
Other checks:
|
|
claude-security-review reviewed Security review: PR #505 (build: bump zizmorcore/zizmor-action to 0.7.1)The review found no security issues. Scope. The PR changes two files, with one line changed in each plus the matching version/commit pair:
What I checked.
Not verified. I could not confirm that manifest: not applicable (no |
…ewrites (#517) Closes #510 ## Summary Every Dependabot bump of a workflow `uses:` SHA or the Dockerfile `FROM` digest failed `Product policy`, because the release checks required those pins to match `release/dependencies.json`, which Dependabot cannot edit ([#505](#505), [#506](#506) and [#514](#514) were the replacement PRs). The pins are now read from the lines Dependabot rewrites. ## Fix - `scripts/ReleasePinSources.ps1` reads the runner image, version and digest from the single `FROM ghcr.io/actions/actions-runner:<v>@sha256:<d>` line, and each external Action's commit and version from its `uses: ...@<sha> # vX.Y.Z` lines. It fails with `file:line` when an Action has no release comment or two uses name different releases. - `Test-ReleasePins.ps1`, `Test-DependencyFreshness.ps1` and `New-CompatibilityManifest.ps1` use those values. `verify-worker-image.sh` and `verify-existing-release.sh` read the `FROM` line. The `compatibility.json` shape is unchanged. - `release/dependencies.json` drops `runner` and `githubActions`, and `Test-ReleasePins.ps1` refuses them if they come back. Checksums, tooling digests, sources and the ci-workflows `repositoryPins` stay. - Runner archive checksum: the image is pulled by digest and never built from the archive, so the hand-copied `archiveSha256` only fed the freshness gate. The gate now compares the asset digest GitHub reports with the SHA-256 published in the runner release notes (`<!-- BEGIN SHA linux-x64 -->`). Both values matched for v2.338.2, v2.338.1, v2.337.0, v2.336.0 and v2.334.0 (`gh api repos/actions/runner/releases/tags/<tag>`). A runner bump therefore needs no checksum edit. - Docs: Action bumps can now pass, so the existing `vendor-actions` lane (`pr-automerge-dependabot.yml`) will auto-merge minor and patch `actions/*`, `github/*` and `anthropics/*` bumps once `ci-status` passes. `docs/releases.md` and `README.md` said no update is ever auto-merged. They now describe that lane. The lane's config is unchanged. ## Verification - `pwsh scripts/Test-ReleasePins.ps1` passes. - `node --test .github/scripts/*.test.cjs` passes (27 tests). The new `release-pins.test.cjs` covers a grouped Action bump and a runner bump with no manifest edit, mismatched SHAs across files, and a missing release comment. - `go test ./...`, shellcheck and shfmt are clean. - Reversing #500's Dockerfile diff and moving zizmor-action to its v0.7.1 pin, with no manifest edit, passes `Test-ReleasePins.ps1`. - The derived Action set is identical to the removed `githubActions` entries. `New-CompatibilityManifest.ps1` emits the same `dependencies` object (runnerVersion 2.338.2). - Not run locally: the full `Test-DependencyFreshness.ps1`, which needs a release token. It runs at the next tag. ## Related - [#510](#510) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01VcupojEVPjg9zYgTTu3TNk --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: replaces Dependabot #501, which cannot pass Product policy on its own.
Summary
Moves
zizmorcore/zizmor-actionin the release workflow from v0.6.4 to v0.7.1. Dependabot's #501 rewrote only the workflow line, soscripts/Test-ReleasePins.ps1:391failed: the pin disagreed withrelease/dependencies.json. This PR carries both edits in one commit.Fix
.github/workflows/release-publish-image.yml:zizmor-action@85b2b9fb8e3325e7a23d7d0a9d7ba5ae0f999e3e # v0.7.1release/dependencies.jsongithubActionsentry: version0.7.1, same commitVerification
gh api repos/zizmorcore/zizmor-action/git/ref/tags/v0.7.1resolves to commit85b2b9fb8e3325e7a23d7d0a9d7ba5ae0f999e3e.node --test .github/scripts/*.test.cjspasses 23/23, and./scripts/Test-ReleasePins.ps1reports the pins as consistent.versionorpersonainputs. The workflow still pinsversion: 1.30.1.Related
Supersedes #501.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VcupojEVPjg9zYgTTu3TNk