ci(release): generate provenance in an isolated reusable workflow (SLSA L3) - #35
Merged
Conversation
…SA L3) Move both provenance attestations (binary checksums + container image) into a new reusable workflow `attest.yml`. A reusable workflow runs with its own OIDC identity the calling build job cannot reach -- the SLSA Build L3 isolation requirement -- while provenance still lands on GitHub's attestation API, so `gh attestation verify` keeps working (the signer-workflow is now attest.yml). - attest.yml (new): isolated attest job; attests binary checksums and/or image provenance; includes its own GHCR login for the image referrer push. - release.yml: the binary job uploads checksums as an artifact and a new attest-binaries job calls attest.yml; the inline image-provenance step moves to a new attest-image job; cosign signing and the syft SBOM attestation stay in-job. Verification commands point at attest.yml. - ghd.toml / stage_ghd_release_assets.py (+ test) / release-dry-run.yml: signer_workflow -> attest.yml. - Docs: README release path, DELETE_ME library-only deletion list. Baked-in fixes from the downstream session-015 shakeout: attest-binaries grants packages:write (a reusable workflow cannot request more than its caller grants, and the shared attest job declares it) [#29], and attest.yml logs in to GHCR before the image attestation push [#33]. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves both provenance attestations (binary checksums + container image) into a new reusable workflow
attest.ymlso signing runs in an isolated OIDC context the build job can't reach — the SLSA Build L3 isolation requirement — while still using GitHub's attestation API (gh attestation verifykeeps working; the signer-workflow is nowattest.yml).This is PR 3 of 3 of the
template-go-apisession-015 migration (PR 1 #30 and PR 2 #31 are merged). It supersedes #32, which GitHub auto-closed when its stacked base branch was deleted after #31 merged; this branch is rebased directly onto master.What changed
.github/workflows/attest.yml(new) — reusable workflow that attests binary checksums and/or image provenance from its own runner/OIDC identity; includes its own GHCR login for the image-referrer push.release.yml—binary-release-assetsdropsid-token/attestationsand uploadschecksums.txtas an artifact; a newattest-binariesjob callsattest.yml. The inline image-provenance step moves to a newattest-imagejob. cosign signing and the syft SBOM attestation stay in-job. Verify commands point atattest.yml.ghd.toml,stage_ghd_release_assets.py(+ test),release-dry-run.yml—signer_workflow/expected_signer→attest.yml.Baked-in fixes from the downstream shakeout
attest-binariesgrantspackages: write(a reusable workflow can't request more than its caller, and the shared attest job declares it).attest.ymllogs in to GHCR before the image-provenance push.Validation
attest.yml+release.yml+release-dry-run.ymlparse cleanly; job DAG well-formed;stage_ghd_release_assets.pyunit suite passes (6/6, incl. wrong-signer rejection and theattest.yml-signer case). The Kusaricache: falsehardening from PR 2 is inherited.🤖 Generated with Claude Code