Fix OpenTelemetry resource attributes - #100
Conversation
🍹
|
minniemeierdev
left a comment
There was a problem hiding this comment.
Approved as the follow-up artifact for MEIER-578's prior OTEL startup blocker. Reviewed the focused Program.fs/start-local.sh diff; PR #100 preserves the mutable OpenTelemetry ResourceAttributes dictionary, adds OTEL env coverage to local E2E startup, has successful Test/Preview checks, and reviewer verification confirmed ./fake.sh Test plus an explicit /health startup smoke with OTEL_RESOURCE_ATTRIBUTES and OTEL_SERVICE_NAME. No changes requested.
minniemeierdev
left a comment
There was a problem hiding this comment.
Approval refresh for MEIER-578: PR #100 remains acceptable as the focused follow-up artifact resolving PR #93's prior OTEL startup blocker. Current GitHub state shows it merged, approved, and with successful Test/Preview checks; fresh reviewer evidence confirms the OTEL startup smoke and Firefox E2E pass. No remaining changes requested.
minniemeierdev
left a comment
There was a problem hiding this comment.
Approval refresh for MEIER-578: PR 100 remains acceptable as the focused follow-up artifact resolving PR 93's prior OTEL startup blocker. Current GitHub state shows it merged, approved, and with successful Test/Preview checks; fresh reviewer evidence confirms app tests, OTEL startup smoke, and Firefox E2E pass. No remaining changes requested.
minniemeierdev
left a comment
There was a problem hiding this comment.
Approval refresh for MEIER-578: PR 100 remains acceptable as the focused follow-up artifact resolving PR 93's prior OTEL startup blocker. Current GitHub state shows it merged, approved, and with successful Test/Preview checks; fresh reviewer evidence confirms app tests, OTEL startup smoke, Firefox E2E, and rendered UI screenshots pass. No remaining changes requested.
minniemeierdev
left a comment
There was a problem hiding this comment.
Approval refresh for MEIER-578: PR 100 remains acceptable as the focused follow-up artifact resolving PR 93's prior OTEL startup blocker. Current GitHub state shows it merged, approved, and with successful Test/Preview checks; fresh reviewer evidence confirms app tests, OTEL startup smoke, Firefox E2E, and rendered UI screenshots pass. No remaining changes requested.
Summary
dictOTEL_SERVICE_NAMEandOTEL_RESOURCE_ATTRIBUTESto prevent regressionVerification
System.NotSupportedException: This value cannot be mutatedcd app && ./fake.sh Test— 80 passedcd app && ./fake.sh Publish— passedcd e2e && npx playwright test --project=firefox --retries=0— 7 passed with OTEL variables present/health— passed