Skip to content

Fix OpenTelemetry resource attributes - #100

Merged
andymeierdev merged 1 commit into
mainfrom
andymeierdev/fix-otel-resource-attributes
Aug 1, 2026
Merged

Fix OpenTelemetry resource attributes#100
andymeierdev merged 1 commit into
mainfrom
andymeierdev/fix-otel-resource-attributes

Conversation

@andymeierdev

Copy link
Copy Markdown
Collaborator

Summary

  • add the service name to the OpenTelemetry sink's existing mutable resource-attribute dictionary
  • stop replacing that dictionary with an immutable F# dict
  • run local E2E with OTEL_SERVICE_NAME and OTEL_RESOURCE_ATTRIBUTES to prevent regression

Verification

  • reproduced the pre-fix System.NotSupportedException: This value cannot be mutated
  • cd app && ./fake.sh Test — 80 passed
  • cd app && ./fake.sh Publish — passed
  • cd e2e && npx playwright test --project=firefox --retries=0 — 7 passed with OTEL variables present
  • explicit startup smoke with both OTEL variables and /health — passed

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

🍹 preview on andymeier/prod

Pulumi report

View in Pulumi Cloud

  Previewing update (prod)

View Live: https://app.pulumi.com/meiermade/andymeier/prod/previews/41e4a4b6-9444-49bc-83e5-8cd7e02a18cc

pulumi:pulumi:Stack: (same)
  [urn=urn:pulumi:prod::andymeier::pulumi:pulumi:Stack::andymeier-prod]
  ~ docker-build:index:Image: (update)
      [id=sha256:ce2a92a5ac3610bf75a8e4d0bd3af7000f4199af0b2612252179582b79ae116c]
      [urn=urn:pulumi:prod::andymeier::docker-build:index:Image::andymeier]
    - contextHash: "7edf45afd61449ff9e6fd53da8822dc9012c44379513bc9d3e3e883a81457eac"
  ~ kubernetes:apps/v1:Deployment: (update)
      [id=andymeier/app]
      [urn=urn:pulumi:prod::andymeier::kubernetes:apps/v1:Deployment::app]
    ~ spec: {
        ~ template: {
            ~ spec: {
                ~ containers: [
                    ~ [0]: {
                            ~ image: "us-east1-docker.pkg.dev/meiermade-platform/platform/andymeier:latest@sha256:741dfeb9ec439c0d9b77fc132ed809164a5160c97c9abc1c27ba5de65da77b53" => [unknown]
                          }
                  ]
              }
          }
      }
Resources:
  ~ 2 to update
  11 unchanged
  

@andymeierdev
andymeierdev merged commit d689235 into main Aug 1, 2026
2 checks passed
@andymeierdev
andymeierdev deleted the andymeierdev/fix-otel-resource-attributes branch August 1, 2026 09:45

@minniemeierdev minniemeierdev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as the follow-up artifact for MEIER-578's prior OTEL startup blocker. Reviewed the focused Program.fs/start-local.sh diff; PR #100 preserves the mutable OpenTelemetry ResourceAttributes dictionary, adds OTEL env coverage to local E2E startup, has successful Test/Preview checks, and reviewer verification confirmed ./fake.sh Test plus an explicit /health startup smoke with OTEL_RESOURCE_ATTRIBUTES and OTEL_SERVICE_NAME. No changes requested.

@minniemeierdev minniemeierdev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval refresh for MEIER-578: PR #100 remains acceptable as the focused follow-up artifact resolving PR #93's prior OTEL startup blocker. Current GitHub state shows it merged, approved, and with successful Test/Preview checks; fresh reviewer evidence confirms the OTEL startup smoke and Firefox E2E pass. No remaining changes requested.

@minniemeierdev minniemeierdev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval refresh for MEIER-578: PR 100 remains acceptable as the focused follow-up artifact resolving PR 93's prior OTEL startup blocker. Current GitHub state shows it merged, approved, and with successful Test/Preview checks; fresh reviewer evidence confirms app tests, OTEL startup smoke, and Firefox E2E pass. No remaining changes requested.

@minniemeierdev minniemeierdev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval refresh for MEIER-578: PR 100 remains acceptable as the focused follow-up artifact resolving PR 93's prior OTEL startup blocker. Current GitHub state shows it merged, approved, and with successful Test/Preview checks; fresh reviewer evidence confirms app tests, OTEL startup smoke, Firefox E2E, and rendered UI screenshots pass. No remaining changes requested.

@minniemeierdev minniemeierdev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval refresh for MEIER-578: PR 100 remains acceptable as the focused follow-up artifact resolving PR 93's prior OTEL startup blocker. Current GitHub state shows it merged, approved, and with successful Test/Preview checks; fresh reviewer evidence confirms app tests, OTEL startup smoke, Firefox E2E, and rendered UI screenshots pass. No remaining changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants