Skip to content

feat: wall resizing by editing dimension label - #14

Open
SSakibHossain10 wants to merge 2 commits into
mehanix:masterfrom
SSakibHossain10:resize_wall_by_typing
Open

feat: wall resizing by editing dimension label#14
SSakibHossain10 wants to merge 2 commits into
mehanix:masterfrom
SSakibHossain10:resize_wall_by_typing

Conversation

@SSakibHossain10

Copy link
Copy Markdown
Contributor

Allows users to click on the wall dimension label and type a custom value
to resize the wall directly.

arcada-label-change-size.mp4

Closes #13

@SSakibHossain10

Copy link
Copy Markdown
Contributor Author

Hi @mehanix I've implemented the feature to allow resizing walls by editing the dimension label (#13).

Feel free to take a look and let me know if you'd like any changes or adjustments.

Thanks!

@mehanix

mehanix commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Hi @SSakibHossain10 ! Thank you for your contribution. Unfortunately there are some bugs that prevent me from merging this to master:

  • when switching from one label to another, the writing caret stays behind
  • when moving the nodes, the writing caret stays behind
  • there is no sanitization for negative values, or entering letters. They don't show up on the label but they make the updating behave erratically.

My apologies for not taking a look at this earlier. It would be wonderful if you could patch the above, if you want. The idea itself is good and would allow for greater ease of use in the editor.

Thank you!

@SSakibHossain10

Copy link
Copy Markdown
Contributor Author

Hi @SSakibHossain10 ! Thank you for your contribution. Unfortunately there are some bugs that prevent me from merging this to master:

  • when switching from one label to another, the writing caret stays behind
  • when moving the nodes, the writing caret stays behind
  • there is no sanitization for negative values, or entering letters. They don't show up on the label but they make the updating behave erratically.

My apologies for not taking a look at this earlier. It would be wonderful if you could patch the above, if you want. The idea itself is good and would allow for greater ease of use in the editor.

Thank you!

Thank you, @mehanix for the review and feedback! I'll look into these issues when I have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resizing wall by typing in dimensions

2 participants