You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @SSakibHossain10 ! Thank you for your contribution. Unfortunately there are some bugs that prevent me from merging this to master:
when switching from one label to another, the writing caret stays behind
when moving the nodes, the writing caret stays behind
there is no sanitization for negative values, or entering letters. They don't show up on the label but they make the updating behave erratically.
My apologies for not taking a look at this earlier. It would be wonderful if you could patch the above, if you want. The idea itself is good and would allow for greater ease of use in the editor.
Hi @SSakibHossain10 ! Thank you for your contribution. Unfortunately there are some bugs that prevent me from merging this to master:
when switching from one label to another, the writing caret stays behind
when moving the nodes, the writing caret stays behind
there is no sanitization for negative values, or entering letters. They don't show up on the label but they make the updating behave erratically.
My apologies for not taking a look at this earlier. It would be wonderful if you could patch the above, if you want. The idea itself is good and would allow for greater ease of use in the editor.
Thank you!
Thank you, @mehanix for the review and feedback! I'll look into these issues when I have some time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to click on the wall dimension label and type a custom value
to resize the wall directly.
arcada-label-change-size.mp4
Closes #13